Skip to content

bpo-32822: Add finally with return/break/continue to the tutorial #25600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 4, 2021
Merged

bpo-32822: Add finally with return/break/continue to the tutorial #25600

merged 2 commits into from
May 4, 2021

Conversation

robertohueso
Copy link
Contributor

@robertohueso robertohueso commented Apr 25, 2021 •
edited
Loading

Hi everyone, this is my first PR to cpython, so any feedback/advice is more than welcome 😄.
This behavior is documented in the reference but not in the tutorial.

https://bugs.python.org/issue32822

@robertohueso
Add finally with return/break/continue to tutorial
02e27fd 
This documents in the tutorial docs the behavior of a finally clause in
case it should re-raise an exception but contains a
return/break/continue statement.
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@robertohueso

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Apr 25, 2021
zware
zware approved these changes Apr 29, 2021
View reviewed changes
Copy link
Member

@zware zware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, very nice first patch! I will leave this for a couple of days to give interested parties from the issue a chance to respond, but if there's been no action in a week please ping me and I'll get it merged.

@ambv ambv merged commit a0b9915 into python:main May 4, 2021
@bedevere-bot
Copy link

@ambv: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington
Copy link
Contributor

Thanks @robertohueso for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@bedevere-bot
Copy link

GH-25890 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 4, 2021
@robertohueso @miss-islington
bpo-32822: Add finally with return/break/continue to the tutorial (py…
6bfcdb1 
…thonGH-25600)

This documents in the tutorial docs the behavior of a finally clause in
case it should re-raise an exception but contains a
return/break/continue statement.
(cherry picked from commit a0b9915)

Co-authored-by: Roberto Hueso <[email protected]>
@ambv ambv added the needs backport to 3.10 only security fixes label May 4, 2021
@miss-islington
Copy link
Contributor

Thanks @robertohueso for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @robertohueso and @ambv, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker a0b9915a8be98427432e13d8eb2207a8b9824179 3.10

@ambv ambv added needs backport to 3.10 only security fixes and removed needs backport to 3.10 only security fixes labels May 4, 2021
@miss-islington
Copy link
Contributor

Thanks @robertohueso for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-25893 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label May 4, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 4, 2021
@robertohueso @miss-islington
bpo-32822: Add finally with return/break/continue to the tutorial (py…
886d9e6 
…thonGH-25600)

This documents in the tutorial docs the behavior of a finally clause in
case it should re-raise an exception but contains a
return/break/continue statement.
(cherry picked from commit a0b9915)

Co-authored-by: Roberto Hueso <[email protected]>
ambv pushed a commit that referenced this pull request May 4, 2021
@miss-islington @robertohueso
bpo-32822: Add finally with return/break/continue to the tutorial (GH…
91cb1e2 
…-25600) (#25890)

This documents in the tutorial docs the behavior of a finally clause in
case it should re-raise an exception but contains a
return/break/continue statement.
(cherry picked from commit a0b9915)

Co-authored-by: Roberto Hueso <[email protected]>
ambv pushed a commit that referenced this pull request May 4, 2021
@miss-islington @robertohueso
bpo-32822: Add finally with return/break/continue to the tutorial (GH…
8655521 
…-25600) (#25893)

This documents in the tutorial docs the behavior of a finally clause in
case it should re-raise an exception but contains a
return/break/continue statement.
(cherry picked from commit a0b9915)

Co-authored-by: Roberto Hueso <[email protected]>
@pablogsal pablogsal mentioned this pull request Jul 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zware zware zware approved these changes

Assignees

@ambv ambv

Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@robertohueso @the-knights-who-say-ni @bedevere-bot @miss-islington @zware @ambv