Skip to content

gh-88037: Move port validation logic to parsing time #25774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

gh-88037: Move port validation logic to parsing time #25774

wants to merge 1 commit into from
+43 −32

Conversation

miguendes
Copy link
Contributor

@miguendes miguendes commented May 1, 2021 •
edited by bedevere-bot
Loading

@miguendes miguendes force-pushed the bpo-43871 branch 4 times, most recently from 7cf9ace to cf3913e Compare May 1, 2021 12:54
@github-actions
Copy link

github-actions bot commented Jun 3, 2021

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Jun 3, 2021
akulakov
akulakov reviewed Jun 27, 2021
View reviewed changes
akulakov
akulakov reviewed Jun 27, 2021
View reviewed changes
akulakov
akulakov reviewed Jun 27, 2021
View reviewed changes
@miguendes miguendes force-pushed the bpo-43871 branch 2 times, most recently from 5ebd099 to 3419baa Compare July 10, 2021 09:03
MaxwellDupre
MaxwellDupre approved these changes Jul 13, 2022
View reviewed changes
Copy link
Contributor

@MaxwellDupre MaxwellDupre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition

@github-actions github-actions bot removed the stale Stale PR or inactive for long period of time. label Aug 7, 2022
@kenballus kenballus mentioned this pull request Aug 16, 2022
Closed
@gpshead gpshead self-requested a review September 13, 2022 22:12
@kenballus kenballus mentioned this pull request Oct 17, 2022
Merged
@kenballus
Copy link
Contributor

Any update on this? I need this behavior, and have implemented a fix myself. Should I submit another PR?

@gpshead gpshead changed the title bpo-43871: Move port validation logic to parsing time gh-88037: Move port validation logic to parsing time Jan 26, 2023
@gpshead gpshead self-assigned this Jan 26, 2023
@gpshead gpshead added type-bug An unexpected behavior, bug, or error stdlib Python modules in the Lib dir labels Jan 26, 2023
@gpshead
Copy link
Member

gpshead commented May 20, 2023

Any update on this? I need this behavior, and have implemented a fix myself. Should I submit another PR?

@kenballus indeed, looks like this one has stalled. a new up to date PR against main (based on this if that makes sense to do) would help.

@p-alik p-alik mannequin mentioned this pull request Nov 23, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akulakov akulakov akulakov left review comments

@MaxwellDupre MaxwellDupre MaxwellDupre approved these changes

@gpshead gpshead Awaiting requested review from gpshead

Assignees

@gpshead gpshead

Labels
awaiting core review stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@miguendes @kenballus @gpshead @akulakov @MaxwellDupre @the-knights-who-say-ni @ezio-melotti @bedevere-bot