Skip to content

bpo-44334: Use bytearray in urllib.unquote_to_bytes #26576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

mostafadafatersa
Copy link

@mostafadafatersa mostafadafatersa commented Jun 7, 2021

In case of form contain very large data ( in my case the string to parse was about 6000000 byte )
Old code use list of bytes during parsing consumes a lot of memory
New code will use bytearry , which use less memory

https://bugs.python.org/issue44334

In case of form contain very large data ( in my case the string to parse was about 6000000 byte )
Old code use list of bytes during parsing consumes a lot of memory 
New code will use bytearry , which use less memory
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@mostafadafatersa

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@mostafadafatersa mostafadafatersa changed the title Save memory when parsing encode 44334: Summary of the changes made Jun 7, 2021
@mostafadafatersa mostafadafatersa changed the title 44334: Summary of the changes made bpo-44334: Summary of the changes made Jun 7, 2021
@mostafadafatersa mostafadafatersa changed the base branch from 3.9 to main June 7, 2021 15:20
@mostafadafatersa mostafadafatersa requested review from tiran, vsajip, warsaw and a team as code owners June 7, 2021 15:20
@mostafadafatersa mostafadafatersa changed the base branch from main to 3.9 June 7, 2021 15:21
@brettcannon brettcannon removed their request for review June 7, 2021 19:14
@terryjreedy terryjreedy changed the title bpo-44334: Summary of the changes made bpo-44334: Use bytearray in urllib.unquote_to_bytes Jun 7, 2021
@terryjreedy
Copy link
Member

terryjreedy commented Jun 7, 2021

Before doing anything more, sign the CLA. Merging into 3.9 is not valid and is likely the reason for the spurious review requests. Make a new PR in which you create a branch from main and then compare and propose to merge it into main. Read devguide.python.org, which should make this clear.

EDIT: Changing the base branch from 3.9 to main should have worked right if your patch-1 branch were a branch of main, but since it did not, it was perhaps a branch of 3.9 or something other than what it needed to be. Since the changes are few, start over with a fresh branch derived from main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants