Skip to content

Run address sanitiser in the GitHub CI #26640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 10, 2021
Merged

Run address sanitiser in the GitHub CI #26640

merged 2 commits into from
Jun 10, 2021

Conversation

pablogsal
Copy link
Member

No description provided.

@markshannon
Copy link
Member

Looks like you've found an X11 bug.
I don't where the X11 bug tracker is. Somewhere in https://gitlab.freedesktop.org/ probably.

@markshannon
Copy link
Member

I'd exclude the failing tests for now and add a note somewhere to revisit the exclusions in a month or two.

- name: Display build info
run: make pythoninfo
- name: Tests
run: xvfb-run make buildbottest TESTOPTS="-j4 -uall,-cpu -x test_ctypes test_capi test_crypt test_decimal test_faulthandler test_interpreters"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add test___all__ test_idle test_tix test_tk test_ttk_guionly test_ttk_textonly to this list.

@vstinner
Copy link
Member

Rather than putting -x test_ctypes test_crypt test_decimal test_faulthandler test_interpreters test___all__ test_idle test_tix test_tk test_ttk_guionly test_ttk_textonly list in the CI configuration, what do you think of adding an option to regrtest, similar to --pgo? Example: add --asan option.

@pablogsal
Copy link
Member Author

Rather than putting -x test_ctypes test_crypt test_decimal test_faulthandler test_interpreters test___all__ test_idle test_tix test_tk test_ttk_guionly test_ttk_textonly list in the CI configuration, what do you think of adding an option to regrtest, similar to --pgo? Example: add --asan option.

👍 Makes sense, that's clearly a better option

@markshannon
Copy link
Member

markshannon commented Jun 10, 2021

--pgo describes what it does, whereas --asan would not.
I know it is clumsy to have to list all the exceptions, but that makes it clear what is excluded.
We want to make the list shorter, having this long list makes it clear what needs fixing.

@pablogsal
Copy link
Member Author

Yeah, that makes sense, although it may be worth to also add some option so you can easily run this locally. I think we should also add something to the devguide about what is excluded and why.

In any case, I am going to merge this and add the option to regrtest in a separate PR.

@pablogsal pablogsal merged commit f82262b into python:main Jun 10, 2021
@pablogsal pablogsal deleted the asan branch June 10, 2021 17:47
@vstinner
Copy link
Member

I know it is clumsy to have to list all the exceptions, but that makes it clear what is excluded.

My concern is that there is also an ASAN buildbot, and this denylist is copied manually. It increases the maintenance burden. Well, since @pablogsal runs the buildbot, he is likely eagger to maintain these two lists manually ;-)

Maybe an option is not needed, and regrtest could detected if Python was built with ASAN using sysconfig to get compiler flags.

We want to make the list shorter, having this long list makes it clear what needs fixing.

Sure, it would be great to skip less tests ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants