Skip to content

Improve consistency of colorsys.rgb_to_hsv #27277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 23, 2021

Conversation

seb-hub
Copy link
Contributor

@seb-hub seb-hub commented Jul 21, 2021

Cache repeated difference to make code easier to read and consistent with colorsys.rgb_to_hls.

Cache repeated difference to make code easier to read and consistent with colorsys.rgb_to_hls.
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@seb-hub

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@seb-hub seb-hub changed the title Improve consistency of colorsys.rgb_to_hsv Skip Issue: Improve Consistency of colorsys.rgb_to_hsv Jul 21, 2021
@seb-hub seb-hub changed the title Skip Issue: Improve Consistency of colorsys.rgb_to_hsv Skip issue: Improve consistency of colorsys.rgb_to_hsv Jul 21, 2021
@nanjekyejoannah nanjekyejoannah changed the title Skip issue: Improve consistency of colorsys.rgb_to_hsv Improve consistency of colorsys.rgb_to_hsv Jul 23, 2021
Copy link
Contributor

@nanjekyejoannah nanjekyejoannah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @seb-hub

@seb-hub
Copy link
Contributor Author

seb-hub commented Jul 23, 2021

Thanks for the fast review, @nanjekyejoannah and @Fidget-Spinner.

@seb-hub seb-hub deleted the patch-1 branch July 23, 2021 13:21
@Fidget-Spinner
Copy link
Member

@seb-hub congrats on landing your first PR in cpython. Hope to see you around :).

@seb-hub
Copy link
Contributor Author

seb-hub commented Jul 23, 2021

@Fidget-Spinner: It's been quite exciting for me :-)
I will look out for other possibilities to contribute!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants