-
-
Notifications
You must be signed in to change notification settings - Fork 32k
Improve consistency of colorsys.rgb_to_hsv #27277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Cache repeated difference to make code easier to read and consistent with colorsys.rgb_to_hls.
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). Recognized GitHub usernameWe couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames: This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @seb-hub
Thanks for the fast review, @nanjekyejoannah and @Fidget-Spinner. |
@seb-hub congrats on landing your first PR in cpython. Hope to see you around :). |
@Fidget-Spinner: It's been quite exciting for me :-) |
Cache repeated difference to make code easier to read and consistent with colorsys.rgb_to_hls.