Skip to content

bpo-44849: Fix os.set_inheritable() on FreeBSD 14 with O_PATH #27623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 6, 2021
Merged

bpo-44849: Fix os.set_inheritable() on FreeBSD 14 with O_PATH #27623

merged 1 commit into from
Aug 6, 2021

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Aug 6, 2021

Fix the os.set_inheritable() functon on FreeBSD 14 for file
descriptor opened with the O_PATH flag: ignore the EBADF error on
ioctl(), fallback on the fcntl() implementation.

https://bugs.python.org/issue44849

@vstinner
Copy link
Member Author

vstinner commented Aug 6, 2021

cc @methane @pablogsal

Fix the os.set_inheritable() function on FreeBSD 14 for file
descriptor opened with the O_PATH flag: ignore the EBADF error on
ioctl(), fallback on the fcntl() implementation.
@vstinner
Copy link
Member Author

vstinner commented Aug 6, 2021

Oops, I fixed a typo: functon => function.

@vstinner vstinner merged commit c24896c into python:main Aug 6, 2021
@vstinner vstinner deleted the set_inheritable_o_path branch August 6, 2021 13:16
@vstinner vstinner added needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes labels Aug 6, 2021
@miss-islington
Copy link
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @vstinner, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker c24896c0e3b32c8a9f614ef51366007b67d5c665 3.10

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 6, 2021
…GH-27623)

Fix the os.set_inheritable() function on FreeBSD 14 for file
descriptor opened with the O_PATH flag: ignore the EBADF error on
ioctl(), fallback on the fcntl() implementation.
(cherry picked from commit c24896c)

Co-authored-by: Victor Stinner <[email protected]>
@bedevere-bot
Copy link

GH-27630 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Aug 6, 2021
@vstinner vstinner added needs backport to 3.10 only security fixes and removed needs backport to 3.10 only security fixes labels Aug 6, 2021
@miss-islington
Copy link
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 6, 2021
…GH-27623)

Fix the os.set_inheritable() function on FreeBSD 14 for file
descriptor opened with the O_PATH flag: ignore the EBADF error on
ioctl(), fallback on the fcntl() implementation.
(cherry picked from commit c24896c)

Co-authored-by: Victor Stinner <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Aug 6, 2021
@bedevere-bot
Copy link

GH-27631 is a backport of this pull request to the 3.10 branch.

miss-islington added a commit that referenced this pull request Aug 6, 2021
Fix the os.set_inheritable() function on FreeBSD 14 for file
descriptor opened with the O_PATH flag: ignore the EBADF error on
ioctl(), fallback on the fcntl() implementation.
(cherry picked from commit c24896c)

Co-authored-by: Victor Stinner <[email protected]>
miss-islington added a commit that referenced this pull request Aug 6, 2021
Fix the os.set_inheritable() function on FreeBSD 14 for file
descriptor opened with the O_PATH flag: ignore the EBADF error on
ioctl(), fallback on the fcntl() implementation.
(cherry picked from commit c24896c)

Co-authored-by: Victor Stinner <[email protected]>
@miss-islington
Copy link
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-28978 is a backport of this pull request to the 3.8 branch.

ambv pushed a commit that referenced this pull request Oct 19, 2021
…) (GH-28978)

Fix the os.set_inheritable() function on FreeBSD 14 for file
descriptor opened with the O_PATH flag: ignore the EBADF error on
ioctl(), fallback on the fcntl() implementation.
(cherry picked from commit c24896c)

Co-authored-by: Victor Stinner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants