-
-
Notifications
You must be signed in to change notification settings - Fork 32k
bpo-45094: Add Py_ALWAYS_INLINE macro #28141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -557,6 +557,28 @@ extern "C" { | |||||
#define _Py_HOT_FUNCTION | ||||||
#endif | ||||||
|
||||||
// Ask the compiler to always inline a static inline function. The compiler is | ||||||
// free is ignored this "hint". This attribute can be used to avoid increasing | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
// the stack memory usage when building Python in debug mode with function | ||||||
// inlining disabled. For example, MSC disables function inlining when building | ||||||
// in debug mode. It should be used on the most commonly used static inline | ||||||
// functions. | ||||||
// | ||||||
// Marking blindly a static inline function with Py_ALWAYS_INLINE can result in | ||||||
// worse performances (due to increased code size for example). The compiler is | ||||||
// usually smarter than the developer for the cost/benefit analysis. | ||||||
// | ||||||
// Usage: | ||||||
// | ||||||
// static inline int Py_ALWAYS_INLINE random(void) { return 4; } | ||||||
#if defined(__GNUC__) || defined(__clang__) || defined(__INTEL_COMPILER) | ||||||
# define Py_ALWAYS_INLINE __attribute__((always_inline)) | ||||||
#elif defined(_MSC_VER) | ||||||
# define Py_ALWAYS_INLINE __forceinline | ||||||
#else | ||||||
# define Py_ALWAYS_INLINE | ||||||
#endif | ||||||
|
||||||
// Py_NO_INLINE | ||||||
// Disable inlining on a function. For example, it reduces the C stack | ||||||
// consumption: useful on LTO+PGO builds which heavily inline code (see | ||||||
|
2 changes: 2 additions & 0 deletions
2
Misc/NEWS.d/next/C API/2021-09-03-16-52-23.bpo-45094.IrTcnE.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
Add :c:macro:`Py_ALWAYS_INLINE` macro to ask the compiler to always inline a | ||
static inline function. Patch by Victor Stinner. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.