Skip to content

bpo-45129 Remove deprecated reuse_address #28207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 8, 2021
Merged

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Sep 7, 2021

Due to significant security concerns, the reuse_address parameter of
asyncio.loop.create_datagram_endpoint, deprecated in Python 3.9, is
now removed. This is because of the behavior of the socket option
SO_REUSEADDR in UDP.

https://bugs.python.org/issue45129

Copy link
Contributor

@ambv ambv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of removing information on reuse_address history from documentation, please:

  • retain versionchanged information for the 3.4.4 and 3.8.1 changes, you can move the "note" on why it was disabled to the versionchanged 3.8.1 section;
  • add a .. versionchanged:: 3.11 and write there that the option disabled since 3.9.0, 3.8.1, 3.7.6, and 3.6.10 has been entirely removed

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Due to significant security concerns, the reuse_address parameter of
asyncio.loop.create_datagram_endpoint, deprecated in Python 3.9, is
now removed. This is because of the behavior of the socket option
SO_REUSEADDR in UDP.
@hugovk
Copy link
Member Author

hugovk commented Sep 7, 2021

Thanks, I have made the requested changes; please review again.

@bedevere-bot
Copy link

Thanks for making the requested changes!

@ambv: please review the changes made to this pull request.

@bedevere-bot bedevere-bot requested a review from ambv September 7, 2021 17:40
@ambv ambv merged commit 59ea704 into python:main Sep 8, 2021
@hugovk hugovk deleted the rm-reuse_address branch September 8, 2021 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants