bpo-45163: haiku build fix proposal. #28269
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devnexen
changed the title
|
I went for it first but then I feared complained about this as it was "just because of haiku" :) |
linkage issues mainly for shared libs and missing system library, also little nit into the signal extension as strsignal returns a constant in this platform.
serhiy-storchaka
added
the
🔨 test-with-buildbots
|
🤖 New build scheduled with the buildbot fleet by @serhiy-storchaka for commit bbdbaf18fa2481c6be7d652c98b7844070b852d3 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
bedevere-bot
removed
the
🔨 test-with-buildbots
|
Are these all necessary changes? |
devnexen
force-pushed
the
haiku_build__fixes
branch
from
bbdbaf1 to
6fd91d8
Compare
|
yes, to make the configure pass correctly. |
serhiy-storchaka
approved these changes
Sep 11, 2021
|
Please add a simple NEWS entry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
linkage issues mainly for shared libs and missing system library,
also little nit into the signal extension as strsignal returns
a constant in this platform.
https://bugs.python.org/issue45163