bpo-45160: Ttk optionmenu only set variable once #28291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is stale because it has been open for 30 days with no activity. |
|
GH-29131 is a backport of this pull request to the 3.10 branch. |
ambv
added
needs backport to 3.9
|
GH-29132 is a backport of this pull request to the 3.9 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 21, 2021
(cherry picked from commit add46f8) Co-authored-by: E-Paine <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 21, 2021
(cherry picked from commit add46f8) Co-authored-by: E-Paine <[email protected]>
ambv
pushed a commit
that referenced
this pull request
Oct 21, 2021
(cherry picked from commit add46f8) Co-authored-by: E-Paine <[email protected]>
ambv
pushed a commit
that referenced
this pull request
Oct 21, 2021
(cherry picked from commit add46f8) Co-authored-by: E-Paine <[email protected]>
ambv
added a commit
that referenced
this pull request
Nov 3, 2021
ambv
added a commit
that referenced
this pull request
Nov 4, 2021
ambv
added a commit
to ambv/cpython
that referenced
this pull request
Nov 4, 2021
ambv
added a commit
that referenced
this pull request
Nov 5, 2021
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 5, 2021
… (pythonGH-29416) (cherry picked from commit 54d1e3f) Co-authored-by: Łukasz Langa <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 5, 2021
… (pythonGH-29416) (cherry picked from commit 54d1e3f) Co-authored-by: Łukasz Langa <[email protected]>
ambv
added a commit
that referenced
this pull request
Nov 5, 2021
…-29416) (GH-29420) (cherry picked from commit 54d1e3f) Co-authored-by: Łukasz Langa <[email protected]>
ambv
added a commit
that referenced
this pull request
Nov 5, 2021
…-29416) (GH-29421) (cherry picked from commit 54d1e3f) Co-authored-by: Łukasz Langa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we were manually setting the variable (as well as the radiobutton), callbacks registered using the variable's
tracemethod would be called twice.TODO: Tests
Note: I probably won't be able to look at this now for ~ a week.
https://bugs.python.org/issue45160