bpo-45198: __set_name__ documentation not clear about its usage with non-descriptor classes #28439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhettinger
added
needs backport to 3.9
|
Thanks @rhettinger for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 18, 2021
…non-descriptor classes (pythonGH-28439) (cherry picked from commit 94b4626) Co-authored-by: Raymond Hettinger <[email protected]>
|
Sorry, @rhettinger, I could not cleanly backport this to |
|
GH-28444 is a backport of this pull request to the 3.10 branch. |
miss-islington
added a commit
that referenced
this pull request
Sep 18, 2021
…non-descriptor classes (GH-28439) (cherry picked from commit 94b4626) Co-authored-by: Raymond Hettinger <[email protected]>
niyas-sait
pushed a commit
to niyas-sait/cpython
that referenced
this pull request
Sep 21, 2021
…non-descriptor classes (pythonGH-28439)
pablogsal
pushed a commit
that referenced
this pull request
Sep 29, 2021
…non-descriptor classes (GH-28439) (cherry picked from commit 94b4626) Co-authored-by: Raymond Hettinger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
__set_name__directly. The example was descriptor specific and the invocation could fail because the descriptor would be triggered by the dotted lookup on the class.__set_name__docs out of the descriptor section and into the general section on class creation.https://bugs.python.org/issue45198