-
-
Notifications
You must be signed in to change notification settings - Fork 32k
bpo-45395: Make custom frozen modules additions instead of replacements. #28778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-45395: Make custom frozen modules additions instead of replacements. #28778
Conversation
Same comment as for #28776 -- do we have any examples of apps that actually use this feature? Would they benefit from this change? |
I don't have examples, other than that |
Aha, so then we should just make sure that Tools/freeze still works. :-) |
87b8b98
to
600d521
Compare
Currently custom modules (the array set on
PyImport_FrozenModules
) replace all the frozen stdlib modules. That can be problematic and is unlikely to be what the user wants. This change treats the custom frozen modules as additions instead. They take precedence over all other frozen modules except for those needed to bootstrap the import system. If the "code" field of an entry in the custom array is NULL then that frozen module is treated as disabled, which allows a custom entry to disable a frozen stdlib module.This change allows us to get rid of
is_essential_frozen_module()
and simplifies the logic for which frozen modules should be ignored.https://bugs.python.org/issue45395