-
-
Notifications
You must be signed in to change notification settings - Fork 32k
Fix docs source link for importlib.metadata #29025
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Ugh, docs are a bit of a pain to keep in sync 😅 |
@jaraco, remember to change the target branch to main and add the backport label 😁 |
We'll want to apply this change to the cpython branch of importlib_metadata also. Otherwise, it might get overwritten during the next update from there. |
The importlib_metadata does not contain this link, it is part of the CPython only header. |
I applied the change at python/importlib_metadata@90083722648. |
Good catch. I not only had to change the target branch, but I had to cherry-pick and force-push the change against |
@flying-sheep: Status check is done, and it's a success ✅ . |
Thanks @flying-sheep for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10. |
The link broke for Python 3.10 since importlib.metadata was made from a module into a package I think this is trivial enough to not need a bpo issue. Automerge-Triggered-By: GH:jaraco (cherry picked from commit aae18a1) Co-authored-by: Philipp A <[email protected]>
GH-29330 is a backport of this pull request to the 3.10 branch. |
The link broke for Python 3.10 since importlib.metadata was made from a module into a package I think this is trivial enough to not need a bpo issue. Automerge-Triggered-By: GH:jaraco (cherry picked from commit aae18a1) Co-authored-by: Philipp A <[email protected]>
The link broke for Python 3.10 since importlib.metadata was made from a module into a package
I think this is trivial enough to not need a bpo issue.
Automerge-Triggered-By: GH:jaraco