Skip to content

Fix docs source link for importlib.metadata #29025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 30, 2021

Conversation

flying-sheep
Copy link
Contributor

@flying-sheep flying-sheep commented Oct 18, 2021

The link broke for Python 3.10 since importlib.metadata was made from a module into a package

I think this is trivial enough to not need a bpo issue.

Automerge-Triggered-By: GH:jaraco

@bedevere-bot bedevere-bot added the docs Documentation in the Doc dir label Oct 18, 2021
@FFY00
Copy link
Member

FFY00 commented Oct 23, 2021

Ugh, docs are a bit of a pain to keep in sync 😅

@FFY00
Copy link
Member

FFY00 commented Oct 23, 2021

@jaraco, remember to change the target branch to main and add the backport label 😁

@jaraco
Copy link
Member

jaraco commented Oct 23, 2021

We'll want to apply this change to the cpython branch of importlib_metadata also. Otherwise, it might get overwritten during the next update from there.

@jaraco jaraco assigned jaraco and unassigned jaraco Oct 23, 2021
@FFY00
Copy link
Member

FFY00 commented Oct 25, 2021

The importlib_metadata does not contain this link, it is part of the CPython only header.

@jaraco
Copy link
Member

jaraco commented Oct 30, 2021

I applied the change at python/importlib_metadata@90083722648.

@jaraco
Copy link
Member

jaraco commented Oct 30, 2021

@jaraco, remember to change the target branch to main and add the backport label 😁

Good catch. I not only had to change the target branch, but I had to cherry-pick and force-push the change against main (because CPython doesn't use the SCM to maintain ancestry of changes).

@jaraco jaraco added the needs backport to 3.10 only security fixes label Oct 30, 2021
@miss-islington
Copy link
Contributor

@flying-sheep: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit aae18a1 into python:main Oct 30, 2021
@miss-islington
Copy link
Contributor

Thanks @flying-sheep for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 30, 2021
The link broke for Python 3.10 since importlib.metadata was made from a module into a package

I think this is trivial enough to not need a bpo issue.

Automerge-Triggered-By: GH:jaraco
(cherry picked from commit aae18a1)

Co-authored-by: Philipp A <[email protected]>
@bedevere-bot
Copy link

GH-29330 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Oct 30, 2021
miss-islington added a commit that referenced this pull request Oct 30, 2021
The link broke for Python 3.10 since importlib.metadata was made from a module into a package

I think this is trivial enough to not need a bpo issue.

Automerge-Triggered-By: GH:jaraco
(cherry picked from commit aae18a1)

Co-authored-by: Philipp A <[email protected]>
@flying-sheep flying-sheep deleted the patch-1 branch October 30, 2021 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants