Skip to content

bpo-45570: Simplify setup macros for pyexpat #29159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 22, 2021

Conversation

tiran
Copy link
Member

@tiran tiran commented Oct 22, 2021

  • HAVE_EXPAT_CONFIG_H is not used by our code and not used by
    system-wide expat header files
  • USE_PYEXPAT_CAPI is no longer used by our code
  • XML_POOR_ENTROPY should be defined in expat_config.h

Signed-off-by: Christian Heimes [email protected]

https://bugs.python.org/issue45570

Automerge-Triggered-By: GH:tiran

* ``HAVE_EXPAT_CONFIG_H`` is not used by our code and not used by
  system-wide expat header files
* ``USE_PYEXPAT_CAPI`` is no longer used by our code
* ``XML_POOR_ENTROPY`` should be defined in expat_config.h

Signed-off-by: Christian Heimes <[email protected]>
@tiran tiran force-pushed the bpo-45570-expat-macros branch from 580d97f to 33385b0 Compare October 22, 2021 13:38
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot ARM64 macOS 3.x has failed when building commit ec93721.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/725/builds/234) and take a look at the build logs.
  4. Check if the failure is related to this commit (ec93721) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/725/builds/234

Failed tests:

  • test_ssl

Failed subtests:

  • test_get_server_certificate_timeout - test.test_ssl.SimpleBackgroundTests

Summary of the results of the build (if available):

== Tests result: FAILURE then FAILURE ==

408 tests OK.

10 slowest tests:

  • test_concurrent_futures: 3 min 28 sec
  • test_multiprocessing_spawn: 2 min 32 sec
  • test_multiprocessing_forkserver: 1 min 53 sec
  • test_unparse: 1 min 28 sec
  • test_asyncio: 1 min 17 sec
  • test_tokenize: 1 min 13 sec
  • test_nntplib: 1 min 1 sec
  • test_lib2to3: 56.1 sec
  • test_logging: 53.1 sec
  • test_capi: 52.2 sec

1 test failed:
test_ssl

16 tests skipped:
test_devpoll test_epoll test_gdb test_ioctl test_msilib
test_multiprocessing_fork test_ossaudiodev test_spwd
test_startfile test_tix test_tk test_ttk_guionly test_winconsoleio
test_winreg test_winsound test_zipfile64

1 re-run test:
test_ssl

Total duration: 8 min 56 sec

Click to see traceback logs
Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/multiprocessing/resource_tracker.py", line 209, in main
    cache[rtype].remove(name)
    ^^^^^^^^^^^^^^^^^^^^^^^^^
KeyError: '/psm_64554f02'


Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/test/test_ssl.py", line 2213, in test_get_server_certificate_timeout
    with self.assertRaises(socket.timeout):
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: TimeoutError not raised


Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/multiprocessing/resource_tracker.py", line 209, in main
    cache[rtype].remove(name)
    ^^^^^^^^^^^^^^^^^^^^^^^^^
KeyError: '/psm_1cbe2cd1'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants