Add missing 'await writer.drain()' call to example #29162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

miss-islington merged 1 commit into python:main from SCORE1387:patch-1

Nov 25, 2021

+1 −0

Contributor

SCORE1387 commented Oct 22, 2021 •

edited by miss-islington

Loading

Automerge-Triggered-By: GH:asvetlov


          Add missing 'await writer.drain()' call to example

1560eb3

SCORE1387 requested review from 1st1 and asvetlov as code owners

October 22, 2021 14:25

the-knights-who-say-ni commented Oct 22, 2021

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

bedevere-bot added the awaiting review label

the-knights-who-say-ni added the CLA not signed label

bedevere-bot added the docs label

the-knights-who-say-ni added CLA signed and removed CLA not signed labels

github-actions bot commented Nov 23, 2021

This PR is stale because it has been open for 30 days with no activity.

github-actions bot added the stale label

asvetlov approved these changes

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting review labels

asvetlov added 🤖 automerge needs backport to 3.10 skip issue skip news labels

Contributor

miss-islington commented Nov 25, 2021

Sorry, I can't merge this PR. Reason: 4 of 6 required status checks are expected..

3 similar comments

Contributor

miss-islington commented Nov 25, 2021

Sorry, I can't merge this PR. Reason: 4 of 6 required status checks are expected..

Contributor

miss-islington commented Nov 25, 2021

Sorry, I can't merge this PR. Reason: 4 of 6 required status checks are expected..

Contributor

miss-islington commented Nov 25, 2021

Sorry, I can't merge this PR. Reason: 4 of 6 required status checks are expected..

Contributor

miss-islington commented Nov 25, 2021

@SCORE1387: Status check is done, and it's a success ✅ .

1 similar comment

Contributor

miss-islington commented Nov 25, 2021

@SCORE1387: Status check is done, and it's a success ✅ .

Contributor

miss-islington commented Nov 25, 2021

Sorry, I can't merge this PR. Reason: 4 of 6 required status checks are expected..

1 similar comment

Contributor

miss-islington commented Nov 25, 2021

Sorry, I can't merge this PR. Reason: 4 of 6 required status checks are expected..

Contributor

asvetlov commented Nov 25, 2021

Thanks!

asvetlov closed this

asvetlov reopened this

Contributor

miss-islington commented Nov 25, 2021

@SCORE1387: Status check is done, and it's a success ✅ .

miss-islington merged commit e0f8a3e into python:main

Contributor

miss-islington commented Nov 25, 2021

Thanks @SCORE1387 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

bedevere-bot removed the awaiting merge label

Contributor

miss-islington commented Nov 25, 2021

Sorry @SCORE1387, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker e0f8a3e9b96bbc2597f61be96993ef0c768a19fe 3.10

miss-islington self-assigned this

remykarem pushed a commit to remykarem/cpython that referenced this pull request


          Add missing 'await writer.drain()' call to example (pythonGH-29162)

f849bcc

Automerge-Triggered-By: GH:asvetlov

ZeroIntensity removed the needs backport to 3.10 label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs skip issue skip news stale