Skip to content

bpo-45624: make test_graphlib not depend on the iteration order of sets #29233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 28, 2021

Conversation

cfbolz
Copy link
Contributor

@cfbolz cfbolz commented Oct 27, 2021

the current test depended on integer sets being iterated on in a certain
fixed order. That order is different on PyPy (insertion based) and could
change in CPython in the future in theory. Make the test robust against
a different iteration order by sorting.

https://bugs.python.org/issue45624

the current test depended on integer sets being iterated on in a certain
fixed order. That order is different on PyPy (insertion based) and could
change in CPython in the future in theory. Make the test robust against
a different iteration order by sorting.
@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting review labels Oct 27, 2021
@cfbolz cfbolz changed the title make test_graphlib not depend on the iteration order of sets bpo-45624: make test_graphlib not depend on the iteration order of sets Oct 27, 2021
@ambv ambv added skip news needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes labels Oct 28, 2021
@ambv ambv merged commit 7401694 into python:main Oct 28, 2021
@miss-islington
Copy link
Contributor

Thanks @cfbolz for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @cfbolz and @ambv, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 7401694807fc6b5f7b35ff73c06f4bb852e02946 3.10

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 28, 2021
…ts (pythonGH-29233)

the current test depended on integer sets being iterated on in a certain
fixed order. That order is different on PyPy (insertion based) and could
change in CPython in the future in theory. Make the test robust against
a different iteration order by sorting.
(cherry picked from commit 7401694)

Co-authored-by: Carl Friedrich Bolz-Tereick <[email protected]>
@bedevere-bot
Copy link

GH-29292 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Oct 28, 2021
@ambv ambv added needs backport to 3.10 only security fixes and removed needs backport to 3.10 only security fixes labels Oct 28, 2021
@miss-islington
Copy link
Contributor

Thanks @cfbolz for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 28, 2021
…ts (pythonGH-29233)

the current test depended on integer sets being iterated on in a certain
fixed order. That order is different on PyPy (insertion based) and could
change in CPython in the future in theory. Make the test robust against
a different iteration order by sorting.
(cherry picked from commit 7401694)

Co-authored-by: Carl Friedrich Bolz-Tereick <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Oct 28, 2021
@bedevere-bot
Copy link

GH-29293 is a backport of this pull request to the 3.10 branch.

ambv pushed a commit that referenced this pull request Oct 28, 2021
…ts (GH-29233) (GH-29292)

the current test depended on integer sets being iterated on in a certain
fixed order. That order is different on PyPy (insertion based) and could
change in CPython in the future in theory. Make the test robust against
a different iteration order by sorting.
(cherry picked from commit 7401694)

Co-authored-by: Carl Friedrich Bolz-Tereick <[email protected]>
ambv pushed a commit that referenced this pull request Oct 28, 2021
…ts (GH-29233) (GH-29293)

the current test depended on integer sets being iterated on in a certain
fixed order. That order is different on PyPy (insertion based) and could
change in CPython in the future in theory. Make the test robust against
a different iteration order by sorting.
(cherry picked from commit 7401694)

Co-authored-by: Carl Friedrich Bolz-Tereick <[email protected]>
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot ARM64 macOS 3.10 has failed when building commit eccb753.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/724/builds/94) and take a look at the build logs.
  4. Check if the failure is related to this commit (eccb753) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/724/builds/94

Summary of the results of the build (if available):

== Tests result: ENV CHANGED ==

407 tests OK.

10 slowest tests:

  • test_concurrent_futures: 3 min 36 sec
  • test_multiprocessing_spawn: 2 min 33 sec
  • test_multiprocessing_forkserver: 1 min 49 sec
  • test_unparse: 1 min 38 sec
  • test_asyncio: 1 min 15 sec
  • test_tokenize: 1 min 14 sec
  • test_lib2to3: 1 min 2 sec
  • test_logging: 1 min 1 sec
  • test_nntplib: 1 min 1 sec
  • test_capi: 55.2 sec

1 test altered the execution environment:
test_ftplib

16 tests skipped:
test_devpoll test_epoll test_gdb test_ioctl test_msilib
test_multiprocessing_fork test_ossaudiodev test_spwd
test_startfile test_tix test_tk test_ttk_guionly test_winconsoleio
test_winreg test_winsound test_zipfile64

Total duration: 9 min 9 sec

Click to see traceback logs
Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.10.pablogsal-macos-m1.macos-with-brew/build/Lib/threading.py", line 1009, in _bootstrap_inner
    self.run()
  File "/Users/buildbot/buildarea/3.10.pablogsal-macos-m1.macos-with-brew/build/Lib/test/test_ftplib.py", line 298, in run
    asyncore.loop(timeout=0.1, count=1)
  File "/Users/buildbot/buildarea/3.10.pablogsal-macos-m1.macos-with-brew/build/Lib/asyncore.py", line 214, in loop
    poll_fun(timeout, map)
  File "/Users/buildbot/buildarea/3.10.pablogsal-macos-m1.macos-with-brew/build/Lib/asyncore.py", line 157, in poll
    read(obj)
  File "/Users/buildbot/buildarea/3.10.pablogsal-macos-m1.macos-with-brew/build/Lib/asyncore.py", line 94, in read
    obj.handle_error()
  File "/Users/buildbot/buildarea/3.10.pablogsal-macos-m1.macos-with-brew/build/Lib/test/test_ftplib.py", line 421, in handle_error
    raise Exception
Exception


Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.10.pablogsal-macos-m1.macos-with-brew/build/Lib/multiprocessing/resource_tracker.py", line 209, in main
    cache[rtype].remove(name)
KeyError: '/psm_fa7162bf'


Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.10.pablogsal-macos-m1.macos-with-brew/build/Lib/asyncore.py", line 90, in read
    obj.handle_read_event()
  File "/Users/buildbot/buildarea/3.10.pablogsal-macos-m1.macos-with-brew/build/Lib/test/test_ftplib.py", line 384, in handle_read_event
    self._do_ssl_handshake()
  File "/Users/buildbot/buildarea/3.10.pablogsal-macos-m1.macos-with-brew/build/Lib/test/test_ftplib.py", line 345, in _do_ssl_handshake
    self.socket.do_handshake()
  File "/Users/buildbot/buildarea/3.10.pablogsal-macos-m1.macos-with-brew/build/Lib/ssl.py", line 1341, in do_handshake
    self._sslobj.do_handshake()
ssl.SSLZeroReturnError: TLS/SSL connection has been closed (EOF) (_ssl.c:997)


Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.10.pablogsal-macos-m1.macos-with-brew/build/Lib/multiprocessing/resource_tracker.py", line 209, in main
    cache[rtype].remove(name)
KeyError: '/psm_4141d3f1'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants