Skip to content

[3.10] bpo-45678: Add functools.singledispatchmethod tests (GH-29328) #29390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 3, 2021

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Nov 3, 2021

(cherry picked from commit 5a14929)

Co-authored-by: Alex Waygood [email protected]

https://bugs.python.org/issue45678

(cherry picked from commit 5a14929)

Co-authored-by: Alex Waygood <[email protected]>
@bedevere-bot bedevere-bot added the tests Tests in the Lib/test dir label Nov 3, 2021
@miss-islington
Copy link
Contributor Author

@AlexWaygood and @ambv: Status check is done, and it's a success ✅ .

@ambv ambv merged commit f191838 into python:3.10 Nov 3, 2021
@miss-islington miss-islington deleted the backport-5a14929-3.10 branch November 3, 2021 16:45
AlexWaygood added a commit to AlexWaygood/cpython that referenced this pull request Nov 3, 2021
…od` bug

This PR fixes a bug in the 3.9 branch where
``functools.singledispatchmethod`` did not properly wrap attributes such as
``__name__``, ``__doc__`` and ``__module__`` of the target method. It also
backports tests already merged into the 3.11 and 3.10 branches in #python#29328 and
python#29390.
ambv added a commit that referenced this pull request Nov 4, 2021
…od` bug (GH-29394)

This PR fixes a bug in the 3.9 branch where
``functools.singledispatchmethod`` did not properly wrap attributes such as
``__name__``, ``__doc__`` and ``__module__`` of the target method. It also
backports tests already merged into the 3.11 and 3.10 branches in #29328 and
#29390.

Co-authored-by: Łukasz Langa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants