Skip to content

bpo-45970: Fix fatal error along the failure path of Py_NewIntperter #29900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

bpo-45970: Fix fatal error along the failure path of Py_NewIntperter #29900

wants to merge 1 commit into from

Conversation

hackhaslam
Copy link

@hackhaslam hackhaslam commented Dec 3, 2021 •
edited by bedevere-bot
Loading

The saved thread state has to be swapped back in before deleting the new
thread state. Otherwise, it causes a fatal error about deleting the current
thread state.

https://bugs.python.org/issue45970

@hackhaslam
bpo-45970: Fix fatal error along the failure path of Py_NewIntperter
b249023 
The saved thread state has to be swapped back in *before* deleting the new
thread state. Otherwise, it causes a fatal error about deleting the current
thread state.
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@hackhaslam

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Jan 11, 2022
@hugovk hugovk mentioned this pull request Feb 17, 2022
Closed
@github-actions
Copy link

Closing this stale PR because the CLA is still not signed.

@github-actions github-actions bot closed this Feb 18, 2022
@hackhaslam hackhaslam mannequin mentioned this pull request Nov 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
awaiting review stale Stale PR or inactive for long period of time.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hackhaslam @the-knights-who-say-ni @bedevere-bot