[docs] Correct typos in SSLContext.sni_callback. #30623
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JelleZijlstra
approved these changes
Jan 19, 2022
hugovk
approved these changes
Feb 10, 2022
There was a problem hiding this comment.
The docs build is unrelated: https://bugs.python.org/issue40066#msg410711
(Rebasing should fix it.)
File "library/enum.rst", line ?, in default
Failed example:
Color(0)
Exception raised:
Traceback (most recent call last):
File "/home/runner/work/cpython/cpython/Lib/doctest.py", line [13](https://github.com/python/cpython/runs/4833263884?check_suite_focus=true#step:9:13)46, in __run
exec(compile(example.source, filename, "single",
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "<doctest default[0]>", line 1, in <module>
Color(0)
^^^^^
NameError: name 'Color' is not defined
|
Should I rebase+force-push? |
|
Better to merge main into this branch. Force push should generally be avoided because it can make reviews harder. We'll squash merge eventually anyway, so the commit history of the PR isn't too important. |
|
I merged main. Seems to be all green now. |
JelleZijlstra
approved these changes
Feb 17, 2022
There was a problem hiding this comment.
Planning to merge in a few days (another small doc fix, cc @gvanrossum).
JelleZijlstra
added
needs backport to 3.9
|
Thanks @joernheissler for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 19, 2022
Co-authored-by: Jörn Heissler <[email protected]> (cherry picked from commit f80a97b) Co-authored-by: Jörn Heissler <[email protected]>
|
GH-31421 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 19, 2022
Co-authored-by: Jörn Heissler <[email protected]> (cherry picked from commit f80a97b) Co-authored-by: Jörn Heissler <[email protected]>
|
GH-31422 is a backport of this pull request to the 3.9 branch. |
miss-islington
added a commit
that referenced
this pull request
Feb 19, 2022
Co-authored-by: Jörn Heissler <[email protected]> (cherry picked from commit f80a97b) Co-authored-by: Jörn Heissler <[email protected]>
JelleZijlstra
pushed a commit
that referenced
this pull request
Feb 21, 2022
Co-authored-by: Jörn Heissler <[email protected]> (cherry picked from commit f80a97b) Co-authored-by: Jörn Heissler <[email protected]>
hello-adam
pushed a commit
to hello-adam/cpython
that referenced
this pull request
Jun 2, 2022
Co-authored-by: Jörn Heissler <[email protected]> (cherry picked from commit f80a97b) Co-authored-by: Jörn Heissler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.