Skip to content

Counter doc mentions three methods, but lists four #30706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 19, 2022
Merged

Counter doc mentions three methods, but lists four #30706

merged 1 commit into from
Feb 19, 2022

Conversation

bruchar1
Copy link
Contributor

Was probably caused by the addition of the total() method

@bruchar1
Counter doc mentions three methods, but lists four
19dd531 
Was probably caused by the addition of the `total()` method
@bruchar1 bruchar1 requested a review from rhettinger as a code owner January 19, 2022 18:44
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@bruchar1

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Jan 19, 2022
@JelleZijlstra JelleZijlstra self-assigned this Feb 17, 2022
JelleZijlstra
JelleZijlstra approved these changes Feb 17, 2022
View reviewed changes
Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Planning to merge this trivial PR (cc @gvanrossum).

@JelleZijlstra
Copy link
Member

But I can't merge because the Windows test failed. It's likely spurious, so I'm going to retrigger CI.

@JelleZijlstra JelleZijlstra reopened this Feb 19, 2022
@JelleZijlstra JelleZijlstra added needs backport to 3.10 only security fixes needs backport to 3.9 only security fixes labels Feb 19, 2022
@JelleZijlstra
Copy link
Member

"three methods" is correct in 3.9, but I'm going to backport there as well to minimize divergence between versions; that will make it easier to apply any further docs changes.

@JelleZijlstra JelleZijlstra merged commit 99331fc into python:main Feb 19, 2022
@miss-islington
Copy link
Contributor

Thanks @bruchar1 for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-31425 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Feb 19, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 19, 2022
@bruchar1 @miss-islington
Counter doc mentions three methods, but lists four (pythonGH-30706)
3c298ca 
Was probably caused by the addition of the `total()` method
(cherry picked from commit 99331fc)

Co-authored-by: Charles Brunet <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 19, 2022
@bruchar1 @miss-islington
Counter doc mentions three methods, but lists four (pythonGH-30706)
9384e44 
Was probably caused by the addition of the `total()` method
(cherry picked from commit 99331fc)

Co-authored-by: Charles Brunet <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Feb 19, 2022
@bedevere-bot
Copy link

GH-31426 is a backport of this pull request to the 3.9 branch.

miss-islington added a commit that referenced this pull request Feb 19, 2022
@miss-islington @bruchar1
Counter doc mentions three methods, but lists four (GH-30706)
75c5dbc 
Was probably caused by the addition of the `total()` method
(cherry picked from commit 99331fc)

Co-authored-by: Charles Brunet <[email protected]>
miss-islington added a commit that referenced this pull request Feb 19, 2022
@miss-islington @bruchar1
Counter doc mentions three methods, but lists four (GH-30706)
cf19932 
Was probably caused by the addition of the `total()` method
(cherry picked from commit 99331fc)

Co-authored-by: Charles Brunet <[email protected]>
hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
@miss-islington @bruchar1 @hello-adam
Counter doc mentions three methods, but lists four (pythonGH-30706)
5e39e0e 
Was probably caused by the addition of the `total()` method
(cherry picked from commit 99331fc)

Co-authored-by: Charles Brunet <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

@rhettinger rhettinger Awaiting requested review from rhettinger rhettinger is a code owner

Assignees

@JelleZijlstra JelleZijlstra

Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@bruchar1 @the-knights-who-say-ni @JelleZijlstra @miss-islington @bedevere-bot @kumaraditya303 @AlexWaygood