bpo-46417: PyWeakref_GET_OBJECT() uses PyWeakref_CheckRef() #30763
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PyWeakref_GET_OBJECT() now ensures that the its argument is valid using PyWeakref_CheckRef(). * Convert PyWeakref_GET_OBJECT() macro to a static inline function. * Remove now redundant assert(PyWeakref_CheckRef(ref)) before PyWeakref_GET_OBJECT(ref) calls. * Add proxy_get_object() to proxy functions. * _ctypes PyDict_GetItemProxy() uses the private _PyWeakref_GET_OBJECT() function. * Cleanup weakrefobject.c.
|
I'm not sure if it's allowed to call PyWeakref_GET_OBJECT() on a proxy reference. My change prevents to do that. In case of doubt, I prefer to abandon my PR. I don't want to take the risk of introducing a backward incompatible change by mistake :-( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PyWeakref_GET_OBJECT() now ensures that the its argument is valid
using PyWeakref_CheckRef().
PyWeakref_GET_OBJECT(ref) calls.
_PyWeakref_GET_OBJECT() function.
https://bugs.python.org/issue46417