Skip to content

bpo-46417: _PyStructSequence_FiniType() updates _Py_RefTotal #30988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 28, 2022
Merged

bpo-46417: _PyStructSequence_FiniType() updates _Py_RefTotal #30988

merged 1 commit into from
Jan 28, 2022

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Jan 28, 2022 •
edited by bedevere-bot
Loading

kumaraditya303
kumaraditya303 approved these changes Jan 28, 2022
View reviewed changes
Copy link
Contributor

@kumaraditya303 kumaraditya303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified with this patch:

@kumaraditya303 ➜ /workspaces/cpython (structseq_fini_reftotal) $ ./python -X showrefcount -c pass
[0 refs, 0 blocks]

@vstinner
Copy link
Member Author

[0 refs, 0 blocks] finally! It's really the first time that I see that in Python! It's a great way to identify remaining issues :-) What comes next: https://bugs.python.org/issue40077#msg411964

@vstinner vstinner merged commit 9a24127 into python:main Jan 28, 2022
@vstinner vstinner deleted the structseq_fini_reftotal branch January 28, 2022 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vstinner @kumaraditya303 @the-knights-who-say-ni @bedevere-bot