[3.9] bpo-46436: Fix command-line option -d/--directory in module http.server (GH-30701) #31103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er (pythonGH-30701) Fix command-line option -d/--directory in http.server main function that was ignored when combined with --cgi. Automerge-Triggered-By: GH:merwok (cherry picked from commit 2d08034) Co-authored-by: Géry Ogam <[email protected]>
|
@maggyero: Status check is done, and it's a success ✅ . |
1 similar comment
|
@maggyero: Status check is done, and it's a success ✅ . |
|
@maggyero: Status check is done, and it's a success ✅ . |
merwok
approved these changes
Feb 3, 2022
raghavthind2005
approved these changes
Feb 8, 2022
|
@raghavthind2005 Please add a comment with approvals to explain what you did (reviewed the code, built python and ran the tests, reviewed the bug report, etc). Otherwise these drive-by approvals provide zero value and only add fake activity to your profile (and people looking at it can tell that these are not real contributions). |
|
Thanks @raghavthind2005 but I concur with @merwok, could you comment about what you did? |
|
Thanks @Mariatta! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix command-line option -d/--directory in http.server main
function that was ignored when combined with --cgi.
Automerge-Triggered-By: GH:merwok
(cherry picked from commit 2d08034)
Co-authored-by: Géry Ogam [email protected]
https://bugs.python.org/issue46436
Automerge-Triggered-By: GH:merwok