Fix mistake in barry_as_FLUFL test #31392
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sweeneyde
added
needs backport to 3.9
|
Thanks @pxeger for the PR, and @sweeneyde for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 18, 2022
Use assertEqual(), not assertTrue(lineno, 2) (cherry picked from commit 5f1c205) Co-authored-by: Patrick Reader <[email protected]>
|
GH-31400 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 18, 2022
Use assertEqual(), not assertTrue(lineno, 2) (cherry picked from commit 5f1c205) Co-authored-by: Patrick Reader <[email protected]>
|
GH-31401 is a backport of this pull request to the 3.9 branch. |
miss-islington
added a commit
that referenced
this pull request
Feb 18, 2022
Use assertEqual(), not assertTrue(lineno, 2) (cherry picked from commit 5f1c205) Co-authored-by: Patrick Reader <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Feb 18, 2022
Use assertEqual(), not assertTrue(lineno, 2) (cherry picked from commit 5f1c205) Co-authored-by: Patrick Reader <[email protected]>
hello-adam
pushed a commit
to hello-adam/cpython
that referenced
this pull request
Jun 2, 2022
Use assertEqual(), not assertTrue(lineno, 2) (cherry picked from commit 5f1c205) Co-authored-by: Patrick Reader <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
Lib/tests/test_flufl.py(which tests thefrom __future__ import barry_as_FLUFLeaster-egg, there is (was) a mistake:This causes
cm.exception.linenoto be checked for truthiness, with2being unintentionally passed as themsgparameter instead. This test will therefore have false negatives, iflinenois for some reason nonzero but incorrect.(How do I do the "skip news" and "skip issue" things for minor changes like this again?)