Skip to content

replace self param with more appropriate cls in classmethods #31402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 20, 2022
Merged

replace self param with more appropriate cls in classmethods #31402

merged 1 commit into from
Feb 20, 2022

Conversation

cmyui
Copy link
Contributor

@cmyui cmyui commented Feb 18, 2022 •
edited
Loading

No worries if this is nitpicky & denied, just noticed while reading through the code & thought I'd PR a fix.

Named correctly in other places such as https://github.com/python/cpython/blob/main/Lib/_collections_abc.py#L622

Also is there any reason why not to use a staticmethod? I'm interested in learning :)

@cmyui cmyui requested a review from rhettinger as a code owner February 18, 2022 02:47
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@cmyui

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

corona10
corona10 previously requested changes Feb 18, 2022
View reviewed changes
Copy link
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the news by using blurb
https://pypi.org/project/blurb/

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

And if you don't make the requested changes, you will be put in the comfy chair!

@corona10 corona10 added needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes labels Feb 18, 2022
@corona10
Copy link
Member

And please sign up the CLA first :)

@serhiy-storchaka
Copy link
Member

No NEWS is need for such kind of changes.

Actually, it would be distracting, because the change does not have any user visible effect.

@asvetlov asvetlov dismissed corona10’s stale review February 20, 2022 12:29

NEWs is not required

@asvetlov
Copy link
Contributor

Let's merge fast; the PR is ready.

@asvetlov asvetlov merged commit a3fcca4 into python:main Feb 20, 2022
@miss-islington
Copy link
Contributor

Thanks @cmyui for the PR, and @asvetlov for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @cmyui and @asvetlov, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker a3fcca4af1cb418dc802feb75100ecc1a286afaa 3.10

@bedevere-bot
Copy link

GH-31445 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Feb 20, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 20, 2022
@cmyui @miss-islington
replace self param with more appropriate cls in classmethods (pyt…
025c730 
…honGH-31402)

(cherry picked from commit a3fcca4)

Co-authored-by: Josh Smith <[email protected]>
asvetlov pushed a commit to asvetlov/cpython that referenced this pull request Feb 20, 2022
@cmyui @asvetlov
[3.10] replace self param with more appropriate cls in classmetho…
f26351b 
…ds (pythonGH-31402)

(cherry picked from commit a3fcca4)

Co-authored-by: Josh Smith <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Feb 20, 2022
@bedevere-bot
Copy link

GH-31446 is a backport of this pull request to the 3.10 branch.

asvetlov added a commit that referenced this pull request Feb 20, 2022
@asvetlov @cmyui
[3.10] replace self param with more appropriate cls in classmetho…
fa621a7 
…ds (GH-31402) (GH-31446)

(cherry picked from commit a3fcca4)

Co-authored-by: Josh Smith <[email protected]>

Co-authored-by: Josh Smith <[email protected]>
@cmyui cmyui deleted the patch-2 branch February 20, 2022 13:57
asvetlov pushed a commit that referenced this pull request Feb 21, 2022
@miss-islington @cmyui
replace self param with more appropriate cls in classmethods (GH-…
e7115d5 
…31402) (#31445)

(cherry picked from commit a3fcca4)

Co-authored-by: Josh Smith <[email protected]>

Co-authored-by: Josh Smith <[email protected]>
hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
@miss-islington @cmyui @hello-adam
replace self param with more appropriate cls in classmethods (pyt…
686658b 
…honGH-31402) (python#31445)

(cherry picked from commit a3fcca4)

Co-authored-by: Josh Smith <[email protected]>

Co-authored-by: Josh Smith <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asvetlov asvetlov asvetlov approved these changes

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@corona10 corona10 corona10 left review comments

@rhettinger rhettinger Awaiting requested review from rhettinger rhettinger is a code owner

Assignees

@asvetlov asvetlov

Labels
skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@cmyui @the-knights-who-say-ni @bedevere-bot @corona10 @serhiy-storchaka @asvetlov @miss-islington