Skip to content

bpo-45150: draft implementation only for sha224,sha256 #31928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

SonOfLilit
Copy link

@SonOfLilit SonOfLilit commented Mar 16, 2022

This is only a draft, after review I will write similar code for all other internal hash implementations, as well as for OpenSSL-based implementations.

https://bugs.python.org/issue45150

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@SonOfLilit

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@gpshead gpshead marked this pull request as draft March 16, 2022 21:07
@gpshead
Copy link
Member

gpshead commented Mar 16, 2022

I do not think we should be writing C code for the initial implementation of this feature. I like where #31930 is headed.

@arhadthedev
Copy link
Member

Superseded by gh-31930.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants