bpo-47081: Replace "qualifiers" with "quantifiers" in the re module documentation #32028
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixxm
approved these changes
Mar 22, 2022
| @@ -230,13 +230,13 @@ while ``+`` requires at least *one* occurrence. To use a similar example, | |||
| ``ca+t`` will match ``'cat'`` (1 ``'a'``), ``'caaat'`` (3 ``'a'``\ s), but won't | |||
| match ``'ct'``. | |||
|
|
|||
| There are two more repeating qualifiers. The question mark character, ``?``, | |||
| There are two more repeating operators or quantifiers. The question mark character, ``?``, | |||
There was a problem hiding this comment.
I think that in this case it is better to keep a line slightly longer that 80 characters than split it on two very short lines or reformat the whole paragraph. PEP 8 allows some liberty.
There was a problem hiding this comment.
I wrongly assumed that in Python docs (as we do in Django docs) re-wrapping is stricter. TIL. Thanks 👍
There was a problem hiding this comment.
Small compromises are possible. If it would be a new text, it would be stricter.
| @@ -87,7 +87,7 @@ Some characters, like ``'|'`` or ``'('``, are special. Special | |||
| characters either stand for classes of ordinary characters, or affect | |||
| how the regular expressions around them are interpreted. | |||
|
|
|||
| Repetition qualifiers (``*``, ``+``, ``?``, ``{m,n}``, etc) cannot be | |||
| Repetition operators or quantifiers (``*``, ``+``, ``?``, ``{m,n}``, etc) cannot be | |||
There was a problem hiding this comment.
It is not PEP 8, but some other PEP for documentation. In any case a common sense is the main principle.
| @@ -146,10 +146,10 @@ The special characters are: | |||
| single: ??; in regular expressions | |||
|
|
|||
| ``*?``, ``+?``, ``??`` | |||
| The ``'*'``, ``'+'``, and ``'?'`` qualifiers are all :dfn:`greedy`; they match | |||
| The ``'*'``, ``'+'``, and ``'?'`` quantifiers are all :dfn:`greedy`; they match | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue47081