rename _imp initialization function to follow conventions #5432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the C imp module became _imp in 6f44d66, the initialization function should have been renamed from PyInit_imp to PyInit__imp.
benjaminp
force-pushed
the
benjamin-rename-imp-init
branch
from
2f002e5 to
0040531
Compare
brettcannon
approved these changes
Jan 29, 2018
zware
approved these changes
Jan 29, 2018
|
@benjaminp: Please replace |
rdb
added a commit
to panda3d/panda3d
that referenced
this pull request
Dec 16, 2018
See python/cpython#5432 - imp module now has the proper name The DL_IMPORT and DL_EXPORT macros seem to have been removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the C imp module became _imp in 6f44d66, the initialization function should have been renamed from PyInit_imp to PyInit__imp.