bpo-29890: Fix IPv*Interface constructor when dealing with tuple #816
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@grapherd, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ncoghlan, @serhiy-storchaka and @hynek to be potential reviewers. |
zhangyangyu
reviewed
Mar 7, 2018
|
|
||
| self.network = IPv4Network(address, strict=False) | ||
| self.netmask = self.network.netmask | ||
| self.netmask, self._prefixlen = self._make_netmask(arg) |
There was a problem hiding this comment.
Is it necessary to calculating again using self._make_netmask? Is self.netmask, self._prefixlen = self.network.netmask, self.network.prefixlen not enough?
|
This change is from an unknown repository and this GitHub account is no longer active. I'm going to close this PR so that another one could be opened to replace it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.