bpo-34449: HP aCC complains about invalid -fPIC on HP-UX #8847
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-o
force-pushed
the
bpo-34449
branch
2 times, most recently
from
bc780bd to
e605974
Compare
-fPIC is code generation option and not a link option. At compile time '+z' is already properly used with HP aCC and shared libraries are correctly linked with '+b'. This switch can safely be dropped. Patch by Michael Osipov.
|
All commit authors signed the Contributor License Agreement. |
|
@michael-o, can you please sign the CLA? |
|
@erlend-aasland I am certain that I already did because other PRs from me have been absorbed into Python already. See here: https://github.com/python/cpython/commits?author=michael-o |
|
Ah, it was a different email address. This I can change. |
|
FYI, CLA is still failing. We cannot merge without it. |
|
@erlend-aasland Just signed. Please check. |
Awesome, 4 years of patience payed out. GCC has been dead for a very long time on HP-UX. |
Misc/NEWS.d/next/Build/2018-08-21-11-10-18.bpo-34449.Z3qm3c.rst
Outdated
Show resolved
Hide resolved
erlend-aasland
approved these changes
May 19, 2022
|
Thanks @michael-o for the PR, and @erlend-aasland for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 19, 2022
…ythonGH-8847) At compile time, '+z' is already properly used with HP aCC, and shared libraries are correctly linked with '+b'. The '-fPIC' switch can safely be dropped. (cherry picked from commit 09be18a) Co-authored-by: Michael Osipov <[email protected]>
|
GH-92977 is a backport of this pull request to the 3.11 branch. |
miss-islington
added a commit
that referenced
this pull request
May 19, 2022
At compile time, '+z' is already properly used with HP aCC, and shared libraries are correctly linked with '+b'. The '-fPIC' switch can safely be dropped. (cherry picked from commit 09be18a) Co-authored-by: Michael Osipov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-fPIC is code generation option and not a link option. At compile time '+z' is
already properly used with HP aCC and shared libraries are correctly linked
with '+b'. This switch can safely be dropped.
Patch by Michael Osipov.
https://bugs.python.org/issue34449