bpo-34594: Fix usage of hardcoded errno values in the tests #9076
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjaminp
reviewed
Sep 6, 2018
Lib/test/test_spwd.py
Outdated
| @@ -68,7 +69,8 @@ def test_getspnam_exception(self): | |||
| except KeyError as exc: | |||
| self.skipTest("spwd entry %r doesn't exist: %s" % (name, exc)) | |||
| else: | |||
| self.assertEqual(str(cm.exception), '[Errno 13] Permission denied') | |||
| self.assertEqual(str(cm.exception), | |||
There was a problem hiding this comment.
I think you can simply delete this assert. What it covers is already handled by catching PermissionError above.
ZackerySpytz
force-pushed
the
bpo-34594-errno-value-tests
branch
from
97c8a6d to
b78a2fd
Compare
|
Thanks @ZackerySpytz for the PR, and @benjaminp for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7. |
|
Sorry, @ZackerySpytz and @benjaminp, I could not cleanly backport this to |
ZackerySpytz
added a commit
to ZackerySpytz/cpython
that referenced
this pull request
Sep 7, 2018
(cherry picked from commit b03c2c5)
ZackerySpytz
added a commit
to ZackerySpytz/cpython
that referenced
this pull request
Sep 7, 2018
(cherry picked from commit b03c2c5)
|
@benjaminp Thanks for the merge. I've created backport PRs for 3.7 (#9094) and 3.6 (#9096). These versions lack |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue34594