gh-92906: Enable test_cppext on Windows #92907
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The Windows test failures are to be expected until #92897 is resolved. |
|
There are merge conflicts now. It may be easier to recreate this change from scratch than try to resolve them. |
|
I tried to add the following code to setup.py, but setup.py stil fails to find include_dirs = []
library_dirs = []
if support.MS_WINDOWS:
# pyconfig.h is created in PCbuild\amd64\
# python313.lib is created in PCbuild\amd64\
src_dir = dirname(dirname(dirname(os.getcwd())))
build_dir = os.path.join(src_dir, 'PCbuild', 'amd64')
include_dirs.append(build_dir)
library_dirs.append(build_dir) |
|
I wrote a new PR from scratch: #117000 PR are now run on Windows, but only on release build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With source build virtual environments sorted out, this test also runs just fine on Windows. Requires #92897.
Adding @vstinner due to recent work on this test.