Skip to content

gh-77057: Fix handling of invalid markup declarations in HTMLParser #9295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 10, 2025

Conversation

ezio-melotti
Copy link
Member

@ezio-melotti ezio-melotti commented Sep 14, 2018

This work-in-progress commit addresses one of the issues reported in bpo-32876.

https://bugs.python.org/issue32876

@ezio-melotti ezio-melotti marked this pull request as draft May 12, 2022 01:29
@erlend-aasland erlend-aasland changed the title bpo-32876: fix handling of invalid markup declarations. (WIP) gh-77057: fix handling of invalid markup declarations. (WIP) Jan 17, 2024
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Dec 15, 2024
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I propose to add addition tests for some cases which were incorrectly handled in parse_marked_section().

@serhiy-storchaka serhiy-storchaka removed the stale Stale PR or inactive for long period of time. label May 7, 2025
@serhiy-storchaka serhiy-storchaka marked this pull request as ready for review May 9, 2025 14:19
@serhiy-storchaka serhiy-storchaka changed the title gh-77057: fix handling of invalid markup declarations. (WIP) gh-77057: fix handling of invalid markup declarations May 9, 2025
@serhiy-storchaka serhiy-storchaka changed the title gh-77057: fix handling of invalid markup declarations gh-77057: Fix handling of invalid markup declarations in HTMLParser May 9, 2025
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@serhiy-storchaka serhiy-storchaka merged commit 76c0b01 into python:main May 10, 2025
43 of 47 checks passed
@serhiy-storchaka serhiy-storchaka added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels May 10, 2025
@miss-islington-app
Copy link

Thanks @ezio-melotti for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks @ezio-melotti for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 10, 2025
…rser (pythonGH-9295)

(cherry picked from commit 76c0b01)

Co-authored-by: Ezio Melotti <[email protected]>
Co-authored-by: Serhiy Storchaka <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 10, 2025
…rser (pythonGH-9295)

(cherry picked from commit 76c0b01)

Co-authored-by: Ezio Melotti <[email protected]>
Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented May 10, 2025

GH-133833 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label May 10, 2025
@bedevere-app
Copy link

bedevere-app bot commented May 10, 2025

GH-133834 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label May 10, 2025
serhiy-storchaka added a commit that referenced this pull request May 10, 2025
…arser (GH-9295) (GH-133834)

(cherry picked from commit 76c0b01)

Co-authored-by: Ezio Melotti <[email protected]>
Co-authored-by: Serhiy Storchaka <[email protected]>
serhiy-storchaka added a commit that referenced this pull request May 10, 2025
…arser (GH-9295) (GH-133833)

(cherry picked from commit 76c0b01)

Co-authored-by: Ezio Melotti <[email protected]>
Co-authored-by: Serhiy Storchaka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants