Clean up the sqlite3 tests #93056
Merged
Clean up the sqlite3 tests #93056
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove helper managed_connect(). Use memory_database() or contextlib.closing() + addCleanup(unlink) instead.
serhiy-storchaka
added
tests
serhiy-storchaka
requested review from
berkerpeksag and
erlend-aasland
as code owners
erlend-aasland
approved these changes
May 21, 2022
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11. |
|
GH-93058 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 21, 2022
Remove helper managed_connect(). Use memory_database() or contextlib.closing() + addCleanup(unlink) instead. (cherry picked from commit e5d8dbd) Co-authored-by: Serhiy Storchaka <[email protected]>
miss-islington
added a commit
that referenced
this pull request
May 21, 2022
Remove helper managed_connect(). Use memory_database() or contextlib.closing() + addCleanup(unlink) instead. (cherry picked from commit e5d8dbd) Co-authored-by: Serhiy Storchaka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove helper
managed_connect(). Usememory_database()orcontextlib.closing() + addCleanup(unlink)instead.In #93047 (comment) @erlend-aasland noticed that the
in_memparameter is ill named. Indeed, themanaged_connect()combines two functions: closing the Connection object and removing the file TESTFN. Andin_mem=Falseparameter was used to suppress the later.Actually, in most cases,
memory_database()can be used instead. And in the leaving three cases wheremanaged_connect()was used it is easy to get rid of it to unify the code.