Skip to content

gh-92886: Remove assert in clinic.permute_optional_groups so that it works when running with optimizations #93228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

gh-92886: Remove assert in clinic.permute_optional_groups so that it works when running with optimizations #93228

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bb9033e
Remove assert in clinic.permute_optional_groups so that it works when…
jackh-ncl May 25, 2022
9d7b09d
📜🤖 Added by blurb_it.
blurb-it[bot] May 25, 2022
653c5be
📜🤖 Added by blurb_it.
blurb-it[bot] May 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Build/2022-05-25-21-23-37.gh-issue-92886.i5gbQo.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Remove assert in :func:`clinic.permute_optional_groups` so that it works as intended, and tests pass, when running with optimizations (``-O``).
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Build/2022-05-25-22-09-19.gh-issue-92886.i5gbQo.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Remove assert in :func:`clinic.permute_optional_groups` so that it works as intended, and tests pass, when running with optimizations (``-O``).
4 changes: 2 additions & 2 deletions Tools/clinic/clinic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -495,8 +495,8 @@ def permute_optional_groups(left, required, right):
required = tuple(required)
result = []

if not required:
assert not left
if not required and left:
raise AssertionError('If required is empty, left must also be empty.')

accumulator = []
counts = set()
Expand Down