-
-
Notifications
You must be signed in to change notification settings - Fork 31.8k
gh-93851: Fix all broken links in Doc/ #93853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 10 commits
d34731f
9a20620
bd5d3d2
c8fa76e
e895a5f
877513b
17aa611
6cdf99a
73ae702
9f6ced4
8665a44
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,13 +4,13 @@ | |
HOWTO Fetch Internet Resources Using The urllib Package | ||
*********************************************************** | ||
|
||
:Author: `Michael Foord <http://www.voidspace.org.uk/python/index.shtml>`_ | ||
:Author: `Michael Foord <https://agileabstractions.com/>`_ | ||
|
||
.. note:: | ||
|
||
There is a French translation of an earlier revision of this | ||
HOWTO, available at `urllib2 - Le Manuel manquant | ||
<http://www.voidspace.org.uk/python/articles/urllib2_francais.shtml>`_. | ||
<http://web.archive.org/web/20200910051922/http://www.voidspace.org.uk/python/articles/urllib2_francais.shtml>`_. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @voidspace The new blog seems to not have Python articles from voidspace.org.uk. It would be great to link to your living blog instead of an archived copy. |
||
|
||
|
||
|
||
|
@@ -22,7 +22,7 @@ Introduction | |
You may also find useful the following article on fetching web resources | ||
with Python: | ||
|
||
* `Basic Authentication <http://www.voidspace.org.uk/python/articles/authentication.shtml>`_ | ||
* `Basic Authentication <http://web.archive.org/web/20201215133350/http://www.voidspace.org.uk/python/articles/authentication.shtml>`_ | ||
|
||
A tutorial on *Basic Authentication*, with examples in Python. | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,7 +4,7 @@ | |
.. module:: importlib.resources | ||
:synopsis: Package resource reading, opening, and access | ||
|
||
**Source code:** :source:`Lib/importlib/resources.py` | ||
**Source code:** :source:`Lib/importlib/resources/__init__.py` | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Note to myself: leave it out while backporting. |
||
|
||
-------------- | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,7 +17,7 @@ re-used. | |
.. deprecated:: 3.6 | ||
``pyvenv`` was the recommended tool for creating virtual environments for | ||
Python 3.3 and 3.4, and is `deprecated in Python 3.6 | ||
<https://docs.python.org/dev/whatsnew/3.6.html#deprecated-features>`_. | ||
<https://docs.python.org/dev/whatsnew/3.6.html#id8>`_. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The link now points to an exact changelog line instead of the whole section. |
||
|
||
.. versionchanged:: 3.5 | ||
The use of ``venv`` is now recommended for creating virtual environments. | ||
|
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -1647,7 +1647,7 @@ for secure (encrypted, authenticated) internet connections: | |||||
* The :func:`ssl.wrap_socket` constructor function now takes a *ciphers* | ||||||
argument. The *ciphers* string lists the allowed encryption algorithms using | ||||||
the format described in the `OpenSSL documentation | ||||||
<https://www.openssl.org/docs/manmaster/man1/ciphers.html#CIPHER-LIST-FORMAT>`__. | ||||||
<https://www.openssl.org/docs/man1.0.2/man1/ciphers.html#CIPHER-LIST-FORMAT>`__. | ||||||
|
||||||
* When linked against recent versions of OpenSSL, the :mod:`ssl` module now | ||||||
supports the Server Name Indication extension to the TLS protocol, allowing | ||||||
|
@@ -2593,10 +2593,12 @@ Changes to Python's build process and to the C API include: | |||||
longer used and it had never been documented (:issue:`8837`). | ||||||
|
||||||
There were a number of other small changes to the C-API. See the | ||||||
:source:`Misc/NEWS` file for a complete list. | ||||||
Misc/NEWS <https://github.com/python/cpython/blob/v3.2.6/Misc/NEWS>`_ | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
For some reason, gh-94078 backport is the only one that caught this typo. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Possibly because it was using the old docs checker script as opposed to Sphinx-Lint. Could you verify whether the latest Sphinx-Lint 0.6.6 catches this case, and if not, could you report it upstream? Thanks! There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Also, it really isn't great that we're regressing from using a dedicated role to hardcoded links...but hopefully the new suite of roles we're developing for this will replace this. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
I ran sphinx-lint 0.6.7 and it caught the typo successfully:
So I hope that adoption of sphinx-lint will eliminate such sporadic discoveries. |
||||||
file for a complete list. | ||||||
|
||||||
Also, there were a number of updates to the Mac OS X build, see | ||||||
:source:`Mac/BuildScript/README.txt` for details. For users running a 32/64-bit | ||||||
`Mac/BuildScript/README.txt <https://github.com/python/cpython/blob/v3.2.6/Mac/BuildScript/README.txt>`_ | ||||||
for details. For users running a 32/64-bit | ||||||
build, there is a known problem with the default Tcl/Tk on Mac OS X 10.6. | ||||||
Accordingly, we recommend installing an updated alternative such as | ||||||
`ActiveState Tcl/Tk 8.5.9 <https://www.activestate.com/activetcl/downloads>`_\. | ||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we just remove this link? The page seems to be very outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, applied. Google prioritized the http version so initially I took whatever it gave.
I believe it goes out of this PR's scope so it deserves a separated PR.