-
-
Notifications
You must be signed in to change notification settings - Fork 32k
gh-93939: Add script to check extension modules #94545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add script ``Tools/scripts/check_modules.py`` to check and validate builtin and shared extension modules. The script also handles ``Modules/Setup`` and will eventually replace ``setup.py``.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"check modules" is very generic. Would you mind to elaborate the purpose of the script? I understand that the purpose is to check which modules are built successfully and which ones are disabled. Maybe say "check modules build"?
It seems like the script also renames extensions which cannot be imported.
Please elaborate the docstring of the script also.
Do you have an idea for a better name? check_extension_modules maybe? |
check_extensions_build or check_built_extensions. |
The script does the same as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updated docstring.
Co-authored-by: Victor Stinner <[email protected]>
Co-authored-by: Victor Stinner <[email protected]>
Co-authored-by: Victor Stinner <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took only a quick glance for now. If this can replace setup.py
, this is a very nice improvement to the build system!
Should we add a check that adds a user-friendly warning if you try to run this script in the source directory? Someone will create an issue about that in the future.
Co-authored-by: Erlend Egeberg Aasland <[email protected]>
Add script
Tools/scripts/check_modules.py
to check and validate builtinand shared extension modules. The script also handles
Modules/Setup
andwill eventually replace
setup.py
.