-
-
Notifications
You must be signed in to change notification settings - Fork 31.8k
docs: remove unneeded hyphens from compound modifiers #94551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I started reading the PR with my mind made up that I dislike changing this because the hyphen makes things easier to a non-native speaker like myself. However, some time through reviewing the changes I "got it". Indeed, the hyphen is unnecessary for the clear case of adverbs followed by an adjective. So yeah, let's do it. Since this is sweeping, it should be backported. Let's see how many conflicts we get 🤠 |
GH-94557 is a backport of this pull request to the 3.11 branch. |
Sorry, @nedbat and @ambv, I could not cleanly backport this to |
…iers (pythonGH-94551) Discussion: https://discuss.python.org/t/slight-grammar-fix-throughout-adverbs-dont-need-hyphen/17021 (cherry picked from commit 3440d19) Co-authored-by: Ned Batchelder <[email protected]>
Since this is a small pervasive change, I'm fine with not back-porting it if it will cause any friction. |
…d modifiers (pythonGH-94551) Discussion: https://discuss.python.org/t/slight-grammar-fix-throughout-adverbs-dont-need-hyphen/17021 (cherry picked from commit 3440d19) Co-authored-by: Ned Batchelder <[email protected]>
The thing is, not backporting will cause more friction in the long term as it will cause conflicts for other docs backports. It's better to deal with those now. 3.11 applied cleanly, 3.10 had a few conflicts which I just resolved. |
GH-94558 is a backport of this pull request to the 3.10 branch. |
…iers (GH-94551) (GH-94557) Discussion: https://discuss.python.org/t/slight-grammar-fix-throughout-adverbs-dont-need-hyphen/17021 (cherry picked from commit 3440d19) Co-authored-by: Ned Batchelder <[email protected]>
…d modifiers (GH-94551) (GH-94558) Discussion: https://discuss.python.org/t/slight-grammar-fix-throughout-adverbs-dont-need-hyphen/17021 (cherry picked from commit 3440d19) Co-authored-by: Ned Batchelder <[email protected]>
pareil, fuzzies vérifiées upstream. Des liens passés en HTTPS, des backquotes rajoutées, et des tirets retirés. Il y a 2-3 PRs qui sont passées upstream et qui provoquent beaucoup de bruit chez nous (des fois pour pas grand chose, particulièrement les tirets). La PR upstream qui retire des tirets partout, pour exemple : python/cpython#94551 travail accompli avec POEdit Pro+ ✌️ Co-authored-by: Mathieu Dupuy <[email protected]> Reviewed-on: https://git.afpy.org/AFPy/python-docs-fr/pulls/106 Reviewed-by: jeanas <[email protected]> Co-authored-by: deronnax <[email protected]> Co-committed-by: deronnax <[email protected]>
This was discussed here: https://discuss.python.org/t/slight-grammar-fix-throughout-adverbs-dont-need-hyphen/17021
(sorry if I haven't provided the correct metadata yet...)