Skip to content

Increase test coverage of Objects/exceptions.c #94674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 8, 2022
Merged

Increase test coverage of Objects/exceptions.c #94674

merged 4 commits into from
Jul 8, 2022

Conversation

iritkatriel
Copy link
Member

Plug a few easy gaps found via @mdboom's test coverage run.

@bedevere-bot bedevere-bot added awaiting core review tests Tests in the Lib/test dir labels Jul 7, 2022
@iritkatriel iritkatriel changed the title increase test coverage of Objects/exceptions.c Increase test coverage of Objects/exceptions.c Jul 7, 2022
iritkatriel
iritkatriel commented Jul 8, 2022
View reviewed changes
kumaraditya303
kumaraditya303 approved these changes Jul 8, 2022
View reviewed changes
Copy link
Contributor

@kumaraditya303 kumaraditya303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it is nice to keep C code coverage high!

@iritkatriel iritkatriel merged commit 4bed0db into python:main Jul 8, 2022
@iritkatriel iritkatriel deleted the exception_tests branch September 29, 2022 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland

Assignees
No one assigned
Labels
skip issue skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iritkatriel @kumaraditya303 @bedevere-bot