-
-
Notifications
You must be signed in to change notification settings - Fork 32k
GH-94438: Handle extended arguments and conditional pops in mark_stacks
#95110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
See also #95113. If we go that route, this PR will need to be updated. |
This will probably tick some coverage boxes in #94808. |
I also noticed that we're not treating |
mark_stacks
mark_stacks
Thanks @brandtbucher for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11. |
Sorry @brandtbucher, I had trouble checking out the |
Thanks @brandtbucher for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11. |
…k_stacks (pythonGH-95110) (cherry picked from commit e4d3a96) Co-authored-by: Brandt Bucher <[email protected]>
GH-95154 is a backport of this pull request to the 3.11 branch. |
…ks (GH-95110) (cherry picked from commit e4d3a96) Co-authored-by: Brandt Bucher <[email protected]>
mark_stacks
hasn't handled extended arguments correctly for some time now:get_arg
helper function checks forEXTENDED_ARG
opcodes, but it should be checking forEXTENDED_ARG_QUICK
(which is what the compiler and_PyCode_GetCode
produce)default
case doesn't callget_arg
, but shouldI've added some regression tests, as well as a few assertions that would have made catching and debugging this issue much easier.