gh-56133: Clarify function/constructor parameter for pickle module #95497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JelleZijlstra
added
needs backport to 3.10
JelleZijlstra
approved these changes
Oct 10, 2022
|
Thanks @slateny for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
|
GH-98131 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 10, 2022
…ythonGH-95497) (cherry picked from commit 281a3f1) Co-authored-by: Stanley <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 10, 2022
…ythonGH-95497) (cherry picked from commit 281a3f1) Co-authored-by: Stanley <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Oct 10, 2022
) (cherry picked from commit 281a3f1) Co-authored-by: Stanley <[email protected]>
JelleZijlstra
added
needs backport to 3.10
|
Thanks @slateny for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 10, 2022
…ythonGH-95497) (cherry picked from commit 281a3f1) Co-authored-by: Stanley <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Oct 10, 2022
) (cherry picked from commit 281a3f1) Co-authored-by: Stanley <[email protected]>
mpage
pushed a commit
to mpage/cpython
that referenced
this pull request
Oct 11, 2022
pablogsal
pushed a commit
that referenced
this pull request
Oct 22, 2022
) (cherry picked from commit 281a3f1) Co-authored-by: Stanley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
dispatch_tabledoc was added in this commit, which adds many more 'copyreg' references to thepickledoc, but finding info on the function/constructor parameter isn't too clear.Constructor argument doesn't seem to do anything:
cpython/Lib/copyreg.py
Lines 17 to 24 in 50b2261