gh-71316: Update dis documentation to include changes to jump arguments #95798
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since 3.10, the instruction offset is used instead of the byte
offset. Thus, for jump instructions, the argument is half
of what it would of been in 3.9. For instance, this code:
def test(x):
return 1 if x else 0
in 3.9 disassembles into
4 0 LOAD_FAST 0 (x)
2 POP_JUMP_IF_FALSE 8
4 LOAD_CONST 1 (1)
6 RETURN_VALUE
>> 8 LOAD_CONST 2 (0)
10 RETURN_VALUE
but in 3.10 disassembles into
4 0 LOAD_FAST 0 (x)
2 POP_JUMP_IF_FALSE 4 (to 8)
4 LOAD_CONST 1 (1)
6 RETURN_VALUE
>> 8 LOAD_CONST 2 (0)
10 RETURN_VALUE
|
All commit authors signed the Contributor License Agreement. |
iritkatriel
reviewed
Oct 7, 2022
iritkatriel
changed the title
|
This is related to #71316. CC @markshannon . |
iritkatriel
added
needs backport to 3.10
iritkatriel
approved these changes
Oct 7, 2022
|
Thanks @Christopher-Chianelli for the PR, and @iritkatriel for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
|
GH-98028 is a backport of this pull request to the 3.11 branch. |
|
Sorry, @Christopher-Chianelli and @iritkatriel, I could not cleanly backport this to |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 7, 2022
…rguments (pythonGH-95798) (cherry picked from commit 6592a62) Co-authored-by: Christopher Chianelli <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Oct 7, 2022
…ts (GH-95798) (cherry picked from commit 6592a62) Co-authored-by: Christopher Chianelli <[email protected]>
Christopher-Chianelli
added a commit
to Christopher-Chianelli/cpython
that referenced
this pull request
Oct 7, 2022
… jump arguments (pythonGH-95798). (cherry picked from commit 6592a62) Co-authored-by: Christopher Chianelli <[email protected]>
Christopher-Chianelli
added a commit
to Christopher-Chianelli/cpython
that referenced
this pull request
Oct 7, 2022
… jump arguments (pythonGH-95798). (cherry picked from commit 6592a62) Co-authored-by: Christopher Chianelli <[email protected]>
|
GH-98029 is a backport of this pull request to the 3.10 branch. |
iritkatriel
pushed a commit
to iritkatriel/cpython
that referenced
this pull request
Oct 7, 2022
iritkatriel
pushed a commit
to iritkatriel/cpython
that referenced
this pull request
Oct 7, 2022
iritkatriel
pushed a commit
that referenced
this pull request
Oct 7, 2022
…arguments (GH-95798). (GH-98029) (cherry picked from commit 6592a62) Co-authored-by: Christopher Chianelli <[email protected]>
mpage
pushed a commit
to mpage/cpython
that referenced
this pull request
Oct 11, 2022
pablogsal
pushed a commit
that referenced
this pull request
Oct 22, 2022
…ts (GH-95798) (cherry picked from commit 6592a62) Co-authored-by: Christopher Chianelli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 3.10, the instruction offset is used instead of the byte
offset. Thus, for jump instructions, the argument is half
of what it would of been in 3.9. For instance, this code:
def test(x):
return 1 if x else 0
in 3.9 disassembles into
4 0 LOAD_FAST 0 (x)
2 POP_JUMP_IF_FALSE 8
4 LOAD_CONST 1 (1)
6 RETURN_VALUE
>> 8 LOAD_CONST 2 (0)
10 RETURN_VALUE
but in 3.10 disassembles into
4 0 LOAD_FAST 0 (x)
2 POP_JUMP_IF_FALSE 4 (to 8)
4 LOAD_CONST 1 (1)
6 RETURN_VALUE
>> 8 LOAD_CONST 2 (0)
10 RETURN_VALUE