Skip to content

gh-95950: Add a test for both csv.Dialect and kwargs #95951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 29, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions Lib/test/test_csv.py
Original file line number Diff line number Diff line change
Expand Up @@ -448,6 +448,34 @@ def test_register_kwargs(self):
self.assertEqual(csv.get_dialect(name).delimiter, ';')
self.assertEqual([['X', 'Y', 'Z']], list(csv.reader(['X;Y;Z'], name)))

def test_register_kwargs_override(self):
class mydialect(csv.Dialect):
delimiter = "\t"
quotechar = '"'
doublequote = True
skipinitialspace = False
lineterminator = '\r\n'
quoting = csv.QUOTE_MINIMAL

name = 'test_dialect'
csv.register_dialect(name, mydialect,
delimiter=';',
quotechar="'",
doublequote=False,
skipinitialspace=True,
lineterminator='\n',
quoting=csv.QUOTE_ALL)
self.addCleanup(csv.unregister_dialect, name)

# Ensure that kwargs do override attributes of a dialect class:
dialect = csv.get_dialect(name)
self.assertEqual(dialect.delimiter, ';')
self.assertEqual(dialect.quotechar, "'")
self.assertEqual(dialect.doublequote, False)
self.assertEqual(dialect.skipinitialspace, True)
self.assertEqual(dialect.lineterminator, '\n')
self.assertEqual(dialect.quoting, csv.QUOTE_ALL)

def test_incomplete_dialect(self):
class myexceltsv(csv.Dialect):
delimiter = "\t"
Expand Down