GH-96179: Fix misleading example on the bisect documentation #96228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All commit authors signed the Contributor License Agreement. |
|
Ugh, forgot to set up the auto-sign commits for the repo (first contribution 😅 ). Is it worth amending and |
encukou
added
skip news
needs backport to 3.10
|
This minor issue does not need a NEWS entry. Could you remove that file? |
|
Sorted @encukou! |
|
Thanks @pedropregueiro for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
|
Thank you, and welcome to Python development! |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 24, 2022
…ythonGH-96228) The `movies[bisect(movies, 1960, key=by_year)]` will actually return only movies **after** 1960. (cherry picked from commit 4317b25) Co-authored-by: prego <[email protected]>
|
GH-96244 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 24, 2022
…ythonGH-96228) The `movies[bisect(movies, 1960, key=by_year)]` will actually return only movies **after** 1960. (cherry picked from commit 4317b25) Co-authored-by: prego <[email protected]>
|
GH-96245 is a backport of this pull request to the 3.10 branch. |
miss-islington
added a commit
that referenced
this pull request
Aug 24, 2022
The `movies[bisect(movies, 1960, key=by_year)]` will actually return only movies **after** 1960. (cherry picked from commit 4317b25) Co-authored-by: prego <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Aug 24, 2022
The `movies[bisect(movies, 1960, key=by_year)]` will actually return only movies **after** 1960. (cherry picked from commit 4317b25) Co-authored-by: prego <[email protected]>
mdboom
pushed a commit
to mdboom/cpython
that referenced
this pull request
Aug 24, 2022
…ythonGH-96228) The `movies[bisect(movies, 1960, key=by_year)]` will actually return only movies **after** 1960.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix minor issue with docs for bisect where example could mislead users:
The
movies[bisect(movies, 1960, key=by_year)]will actually return only movies after 1960.