[3.11] gh-96357: Improve typing.get_overloads coverage (GH-96358)
#96371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 675e347) Co-authored-by: Nikita Sobolev <[email protected]>
miss-islington
requested review from
gvanrossum,
Fidget-Spinner and
JelleZijlstra
as code owners
|
@sobolevn and @JelleZijlstra: Status check is done, and it's a success ❌ . |
|
@sobolevn and @JelleZijlstra: Status check is done, and it's a success ❌ . |
1 similar comment
|
@sobolevn and @JelleZijlstra: Status check is done, and it's a success ❌ . |
|
Will merge after 3.11.0 final. |
|
Offtopic. I am always confused: why status check "is a success", but icon is a red "no-no" sign? Should it be this way? |
|
Yes, that feels like a bug. I think there's been some discussion of it in the core dev discord but I don't recall the cause. |
JelleZijlstra
approved these changes
Sep 21, 2022
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 675e347)
Co-authored-by: Nikita Sobolev [email protected]
typing.get_overloads#96357