Skip to content

gh-96819: check if the length of a pipe write is not greater than 512 #96890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Oct 3, 2022
Merged

gh-96819: check if the length of a pipe write is not greater than 512 #96890

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
2efc372
fix: check the length of `msg`, not the length of `name`
saito828koki Sep 17, 2022
476bed0
📜🤖 Added by blurb_it.
blurb-it[bot] Sep 17, 2022
ee548f9
fix: remove backticks
saito828koki Sep 17, 2022
1566b72
fix: update error message
saito828koki Sep 20, 2022
3f32cb6
modify NEWS entry
saito828koki Sep 20, 2022
1039648
Add a test for too long name resources
saito828koki Oct 1, 2022
30f651c
Modify NEWS entry
saito828koki Oct 1, 2022
6c3afb9
Modify NEWS entry
saito828koki Oct 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Lib/multiprocessing/resource_tracker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ def unregister(self, name, rtype):
def _send(self, cmd, name, rtype):
self.ensure_running()
msg = '{0}:{1}:{2}\n'.format(cmd, name, rtype).encode('ascii')
if len(name) > 512:
if len(msg) > 512:
# posix guarantees that writes to a pipe of less than PIPE_BUF
# bytes are atomic, and that PIPE_BUF >= 512
raise ValueError('name too long')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this also be updated? ie. msg too long?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DanielNoord
Thanks for your comment!
The error message should also be updated. I will fix it.

Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Library/2022-09-17-13-15-10.gh-issue-96819.6RfqM7.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fixed the block to guarantee that the length of a write to a pipe is not greater than PIPE_BUF
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Fixed the block to guarantee that the length of a write to a pipe is not greater than PIPE_BUF
Fixed the check that guarantees that the length of a write to a pipe is not greater than PIPE_BUF

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for correcting my English! Your suggestion seems to be great.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries! I struggle with writing good and short changelog entries myself many times! 😄