Skip to content

gh-96954: Add tests for unicodedata.name/lookup #96955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 21, 2022

Conversation

isidentical
Copy link
Member

@isidentical isidentical commented Sep 20, 2022

They were undertested, and since #96954 might involve a rewrite of this part of the code we want to ensure that there won't be any behavioral change.

Co-authored-by: Carl Friedrich Bolz-Tereick [email protected]

They were undertested, and since python#96954 might involve a
rewrite of this part of the code we want to ensure that
there won't be any behavioral change.

Co-authored-by: Carl Friedrich Bolz-Tereick <[email protected]>
@isidentical isidentical requested a review from ambv September 20, 2022 09:58
@bedevere-bot bedevere-bot added awaiting core review tests Tests in the Lib/test dir labels Sep 20, 2022
@ambv ambv merged commit 5a32eec into python:main Sep 21, 2022
@ambv ambv added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Sep 21, 2022
@miss-islington
Copy link
Contributor

Thanks @isidentical for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington
Copy link
Contributor

Thanks @isidentical for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @isidentical and @ambv, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 5a32eeced2c537c13613dd4ff5b2767a37037294 3.11

@miss-islington
Copy link
Contributor

Sorry @isidentical and @ambv, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 5a32eeced2c537c13613dd4ff5b2767a37037294 3.10

ambv pushed a commit to ambv/cpython that referenced this pull request Sep 21, 2022
…H-96955)

They were undertested, and since pythonGH-96954 might involve a
rewrite of this part of the code we want to ensure that
there won't be any behavioral change.

Co-authored-by: Carl Friedrich Bolz-Tereick <[email protected]>
(cherry picked from commit 5a32eec)

Co-authored-by: Batuhan Taskaya <[email protected]>
@bedevere-bot
Copy link

GH-96991 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Sep 21, 2022
ambv pushed a commit to ambv/cpython that referenced this pull request Sep 21, 2022
…H-96955)

They were undertested, and since pythonGH-96954 might involve a
rewrite of this part of the code we want to ensure that
there won't be any behavioral change.

Co-authored-by: Carl Friedrich Bolz-Tereick <[email protected]>
(cherry picked from commit 5a32eec)

Co-authored-by: Batuhan Taskaya <[email protected]>
@bedevere-bot
Copy link

GH-96992 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Sep 21, 2022
ambv pushed a commit that referenced this pull request Sep 21, 2022
They were undertested, and since GH-96954 might involve a
rewrite of this part of the code we want to ensure that
there won't be any behavioral change.

Co-authored-by: Carl Friedrich Bolz-Tereick <[email protected]>
(cherry picked from commit 5a32eec)

Co-authored-by: Batuhan Taskaya <[email protected]>
ambv added a commit that referenced this pull request Sep 21, 2022
…-96992)

They were undertested, and since GH-96954 might involve a
rewrite of this part of the code we want to ensure that
there won't be any behavioral change.

Co-authored-by: Carl Friedrich Bolz-Tereick <[email protected]>
(cherry picked from commit 5a32eec)

Co-authored-by: Batuhan Taskaya <[email protected]>
ambv added a commit that referenced this pull request Sep 21, 2022
…-96991)

They were undertested, and since GH-96954 might involve a
rewrite of this part of the code we want to ensure that
there won't be any behavioral change.

Co-authored-by: Carl Friedrich Bolz-Tereick <[email protected]>
(cherry picked from commit 5a32eec)

Co-authored-by: Batuhan Taskaya <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants