Skip to content

gh-98083 Fix URLs in README.rst #98082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 10, 2022
Merged

gh-98083 Fix URLs in README.rst #98082

merged 1 commit into from
Oct 10, 2022

Conversation

kwsp
Copy link
Contributor

@kwsp kwsp commented Oct 8, 2022

There were 2 broken links in README.rst:

Another link to the NEWS.d directory was causing a 301 redirect (since it's a directory and github uses tree instead of blob in the URL), so I fixed that too.

@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir skip news labels Oct 8, 2022
@kwsp kwsp changed the title Fix URLs in README.rst gh-98083 Fix URLs in README.rst Oct 8, 2022
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked links manually and they work correctly. Thanks! :)

@JelleZijlstra JelleZijlstra added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Oct 10, 2022
@JelleZijlstra JelleZijlstra merged commit fc342c6 into python:main Oct 10, 2022
@miss-islington
Copy link
Contributor

Thanks @kwsp for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @kwsp and @JelleZijlstra, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker fc342c62e0debb194d60e79b37e346bf8d940d7a 3.10

@bedevere-bot
Copy link

GH-98135 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 10, 2022
(cherry picked from commit fc342c6)

Co-authored-by: Tiger <[email protected]>
@JelleZijlstra
Copy link
Member

Thanks for your fix!

Feel free to manually create a 3.10 backport, but it's probably not too important since I expect people don't usually read the README on branches other than the default.

miss-islington added a commit that referenced this pull request Oct 10, 2022
(cherry picked from commit fc342c6)

Co-authored-by: Tiger <[email protected]>
mpage pushed a commit to mpage/cpython that referenced this pull request Oct 11, 2022
@ZeroIntensity ZeroIntensity removed the needs backport to 3.10 only security fixes label Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants