gh-90535: Warn of deprecation of intervals other than 1 with when='MIDNIGHT'
#98099
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettcannon
changed the title
brettcannon
changed the title
when=='MIDNIGHT'
brettcannon
changed the title
when=='MIDNIGHT'when='MIDNIGHT'
brettcannon
reviewed
Nov 25, 2022
| self.fn, encoding="utf-8", when='MIDNIGHT', interval=2, backupCount=0, | ||
| utc=True) | ||
| rh.close() | ||
| if w: |
There was a problem hiding this comment.
Do you want the test to pass if no warning is raised? If not then in the above I would force deprecations on as exceptions via warnings.simplefilter("error").
There was a problem hiding this comment.
Good point. Thanks for the review, Brett.
There was a problem hiding this comment.
Why not use assertWarns()?
| @@ -28,6 +28,7 @@ | |||
| import queue | |||
| import threading | |||
| import copy | |||
| import warnings | |||
There was a problem hiding this comment.
It is better to defer the warnings module import until it is needed (which never happen in normal case).
| self.fn, encoding="utf-8", when='MIDNIGHT', interval=2, backupCount=0, | ||
| utc=True) | ||
| rh.close() | ||
| if w: |
There was a problem hiding this comment.
Why not use assertWarns()?
|
#116220 is an alternate solution, which fixes support of intervals>1 instead of deprecating it for when='MIDNIGHT' and when='Wx'. |
|
I guess it can be closed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.