-
-
Notifications
You must be signed in to change notification settings - Fork 32k
gh-96035: Make urllib.parse.urlparse reject non-numeric ports #98273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
2509db4
pythongh-96035: Make urllib.parse.urlparse reject non-numeric port st…
kenballus 6e6db6b
Merge branch 'python:main' into main
kenballus a41b8e0
Merge branch 'python:main' into main
kenballus 5482221
Merge branch 'python:main' into main
kenballus 98450a6
Add tests and remove nested errors.
kenballus b4ea289
Simplify port number validation. A port is valid iff it consists only…
kenballus 58d8e30
add check for ascii
kenballus 40f1b37
Update Misc/NEWS.d/next/Library/2022-10-14-19-57-37.gh-issue-96035.0x…
kenballus 4b5c236
Merge branch 'main' into main
kenballus 63c74e5
Merge branch 'python:main' into main
kenballus 6a6683b
add test for non-ascii port number
kenballus 67ecd2f
Merge branch 'main' of github.com:kenballus/cpython
kenballus c4c1554
Update Misc/NEWS.d/next/Library/2022-10-14-19-57-37.gh-issue-96035.0x…
kenballus b1aeb37
Merge branch 'python:main' into main
kenballus File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 3 additions & 0 deletions
3
Misc/NEWS.d/next/Library/2022-10-14-19-57-37.gh-issue-96035.0xcX-p.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
Fixes bug in urllib.parse.urlparse that causes certain port numbers | ||
kenballus marked this conversation as resolved.
Show resolved
Hide resolved
|
||
containing whitespace, underscores, or plus and minus signs to be | ||
kenballus marked this conversation as resolved.
Show resolved
Hide resolved
|
||
incorrectly accepted. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.